Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: LayoutTests/editing/pasteboard/input-with-display-none-div.html

Issue 222023002: focus() behaviour differs depending on how value is set (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Adding fix for LayoutTest that are failing Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/editing/pasteboard/input-with-display-none-div.html
diff --git a/LayoutTests/editing/pasteboard/input-with-display-none-div.html b/LayoutTests/editing/pasteboard/input-with-display-none-div.html
index a2b98fe26287d343f36e3cbb2704a57dc7435eaa..737b4d7142fe9f2c06d49be6bc301177237f4044 100644
--- a/LayoutTests/editing/pasteboard/input-with-display-none-div.html
+++ b/LayoutTests/editing/pasteboard/input-with-display-none-div.html
@@ -15,7 +15,7 @@ if (window.testRunner)
testRunner.dumpAsText();
var input = document.querySelector('input');
-input.focus();
+input.select();
tkent 2014/04/11 06:27:17 Why does the test work? We need focus() to make t
harpreet.sk 2014/04/11 07:33:02 Added focus().
tkent 2014/04/11 07:40:20 What's the answer of the question? Why it worked?
harpreet.sk 2014/04/11 08:09:14 For the given layout tests it worked because focus
tkent 2014/04/11 08:19:41 I'm asking if execCommand('InsertHTML', ...) works
harpreet.sk 2014/04/11 08:37:56 Yes it works without focus() and using select() al
tkent 2014/04/11 08:42:14 Thanks. Hmm, it sounds a bug. Anyway, we may proc
document.execCommand('InsertHTML', false, 'PASS');
document.write(input.value);

Powered by Google App Engine
This is Rietveld 408576698