Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: LayoutTests/editing/pasteboard/copy-in-password-field.html

Issue 222023002: focus() behaviour differs depending on how value is set (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Adding fix for LayoutTest that are failing Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/editing/pasteboard/copy-in-password-field.html
diff --git a/LayoutTests/editing/pasteboard/copy-in-password-field.html b/LayoutTests/editing/pasteboard/copy-in-password-field.html
index f9e1ccd77fc0a6a428c0bc9fb7a82c7b92c5c000..78ca776ebce39f0ea86da8357755150146ae3b26 100644
--- a/LayoutTests/editing/pasteboard/copy-in-password-field.html
+++ b/LayoutTests/editing/pasteboard/copy-in-password-field.html
@@ -7,15 +7,15 @@
testRunner.dumpEditingCallbacks();
// Overwrite the old pasteboard with default results
- document.getElementById("text").focus();
+ document.getElementById("text").select();
tkent 2014/04/11 06:27:17 We need .focus() prior to every select(). Withou
harpreet.sk 2014/04/11 07:33:02 Added focus().
document.execCommand("Copy");
// Try to copy a password
- document.getElementById("password").focus();
+ document.getElementById("password").select();
document.execCommand("Copy");
// Paste
- document.getElementById("text").focus();
+ document.getElementById("text").select();
document.execCommand("Paste");
shouldBe('document.getElementById("text").value', '"[not modified]"');

Powered by Google App Engine
This is Rietveld 408576698