Source/core/html/HTMLTextAreaElement.cpp - Issue 222023002: focus() behaviour differs depending on how value is set

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLTextAreaElement.cpp

Issue 222023002: focus() behaviour differs depending on how value is set (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Addressing the changes mention in comments in Patch set 2 Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLTextAreaElement.cpp

diff --git a/Source/core/html/HTMLTextAreaElement.cpp b/Source/core/html/HTMLTextAreaElement.cpp

index 6653cb1b2befa66630985cfe355ea8ec86b94fef..618edc102dff8279d9946dc82e08016dbb9cabdd 100644

--- a/Source/core/html/HTMLTextAreaElement.cpp

+++ b/Source/core/html/HTMLTextAreaElement.cpp

@@ -240,7 +240,7 @@ bool HTMLTextAreaElement::shouldShowFocusRingOnMouseFocus() const

void HTMLTextAreaElement::updateFocusAppearance(bool restorePreviousSelection)

{

- if (!restorePreviousSelection || !hasCachedSelection()) {

+ if (!restorePreviousSelection) {

// If this is the first focus, set a caret at the beginning of the text.

tkent 2014/04/10 01:37:39 This comment is obsolete. Please remove it.

harpreet.sk 2014/04/10 06:13:27 Done.

// This matches some browsers' behavior; see bug 11746 Comment #15.

// http://bugs.webkit.org/show_bug.cgi?id=11746#c15

« no previous file with comments | « Source/core/html/HTMLInputElement.cpp ('k') | Source/core/html/HTMLTextFormControlElement.h » ('j') | no next file with comments »