Source/core/html/HTMLInputElement.cpp - Issue 222023002: focus() behaviour differs depending on how value is set

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLInputElement.cpp

Issue 222023002: focus() behaviour differs depending on how value is set (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Addressing the changes mention in comments in Patch set 2 Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/platform/linux/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt ('k') | Source/core/html/HTMLTextAreaElement.cpp » ('j') | Source/core/html/HTMLTextAreaElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/HTMLInputElement.cpp

diff --git a/Source/core/html/HTMLInputElement.cpp b/Source/core/html/HTMLInputElement.cpp

index 63f70bb35fdb2b68ee17487558df5bca7785d9ea..ce88788fcae01a6d9d0dd6b1a312fac45ad6d562 100644

--- a/Source/core/html/HTMLInputElement.cpp

+++ b/Source/core/html/HTMLInputElement.cpp

@@ -339,7 +339,7 @@ bool HTMLInputElement::shouldShowFocusRingOnMouseFocus() const

void HTMLInputElement::updateFocusAppearance(bool restorePreviousSelection)

{

if (isTextField()) {

- if (!restorePreviousSelection || !hasCachedSelection())

+ if (!restorePreviousSelection)

select();

else

restoreCachedSelection();