Source/core/html/HTMLTextFormControlElement.cpp - Issue 222023002: focus() behaviour differs depending on how value is set

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLTextFormControlElement.cpp

Issue 222023002: focus() behaviour differs depending on how value is set (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixing selection handling of 'value' HTML attribute by initializing m_cachedSelection{Start,End} wi… Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/forms/input-double-click-selection-gap-bug.html ('K') | « LayoutTests/platform/linux/fast/forms/textfield-outline-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/HTMLTextFormControlElement.cpp

diff --git a/Source/core/html/HTMLTextFormControlElement.cpp b/Source/core/html/HTMLTextFormControlElement.cpp

index 2eef6724f42469aa0bf5183a51a484f912ea2d9d..21bf8b6e0c3af24f3388b1164440c93f60aedfdc 100644

--- a/Source/core/html/HTMLTextFormControlElement.cpp

+++ b/Source/core/html/HTMLTextFormControlElement.cpp

@@ -53,8 +53,8 @@ using namespace std;

HTMLTextFormControlElement::HTMLTextFormControlElement(const QualifiedName& tagName, Document& doc, HTMLFormElement* form)

: HTMLFormControlElementWithState(tagName, doc, form)

, m_lastChangeWasUserEdit(false)

- , m_cachedSelectionStart(-1)

- , m_cachedSelectionEnd(-1)

+ , m_cachedSelectionStart(0)

+ , m_cachedSelectionEnd(0)

tkent 2014/04/09 00:16:48 hasCachedSelection() never returns false. We shou

harpreet.sk 2014/04/09 14:19:43 hasCachedSelection() is removed and assertions is

, m_cachedSelectionDirection(SelectionHasNoDirection)

{

}