focus() behaviour differs depending on how value is set

Source/core/html/HTMLTextFormControlElement.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 35 matching lines @@
 #include "wtf/text/StringBuilder.h"
 
 namespace WebCore {
 
 using namespace HTMLNames;
 using namespace std;
 
 HTMLTextFormControlElement::HTMLTextFormControlElement(const QualifiedName& tagName, Document& doc, HTMLFormElement* form)
     : HTMLFormControlElementWithState(tagName, doc, form)
     , m_lastChangeWasUserEdit(false)
-    , m_cachedSelectionStart(-1)
-    , m_cachedSelectionEnd(-1)
+    , m_cachedSelectionStart(0)
+    , m_cachedSelectionEnd(0)

[tkent, 2014/04/09 00:16:48]

hasCachedSelection() never returns false.  We should remove it, and should add
assertions to make sure m_cachedSelection* can't be -1.

[harpreet.sk, 2014/04/09 14:19:43]

hasCachedSelection() is removed and assertions is added where the value of
m_cachedSelection is set.

     , m_cachedSelectionDirection(SelectionHasNoDirection)
 {
 }
 
 HTMLTextFormControlElement::~HTMLTextFormControlElement()
 {
 }
 
 Node::InsertionNotificationRequest HTMLTextFormControlElement::insertedInto(ContainerNode* insertionPoint)
 {
@@ skipping 579 matching lines @@
 
     return "ltr";
 }
 
 HTMLElement* HTMLTextFormControlElement::innerTextElement() const
 {
     return toHTMLElement(userAgentShadowRoot()->getElementById(ShadowElementNames::innerEditor()));
 }
 
 } // namespace Webcore