Rust: Add validation to decode

Rust: Add validation checks to decode

In the Rust bindings we now perform validation of the input
buffer on Mojom decode. The generated code checked in for
tests has been updated as well in order to test validation in
nearly all of the cases outlined in the "golden" files.

The only missing tests to run are the integration tests which
are to come in a future CL.

R=eholk@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/4fbb11a4a65151bbc73545a9f2dbc4627db9d0a0

[mknyszek, 2016-08-08 20:03:28]

mknyszek@google.com changed reviewers:
+ eholk@chromium.org, jamesr@chromium.org, phosek@google.com

[mknyszek, 2016-08-08 20:03:28]

Added validation code to the decode path.

[Eric Holk, 2016-08-08 20:34:15]

lgtm

https://codereview.chromium.org/2220183003/diff/20001/mojo/public/rust/tests/...
File mojo/public/rust/tests/util/mojom_validation.rs (right):

https://codereview.chromium.org/2220183003/diff/20001/mojo/public/rust/tests/...
mojo/public/rust/tests/util/mojom_validation.rs:361: match
state.decode_struct_header(&StructGVersions) {
You use this pattern a lot, but I think it's basically the try! macro. Would
that work for you?

https://doc.rust-lang.org/std/result/index.html#the-try-macro

Actually, I forgot that this file was generated code, so I wouldn't worry about
the try! macro. If you have it outside of here, it will probably make your code
a lot cleaner.

[mknyszek, 2016-08-08 21:32:22]

https://codereview.chromium.org/2220183003/diff/20001/mojo/public/rust/tests/...
File mojo/public/rust/tests/util/mojom_validation.rs (right):

https://codereview.chromium.org/2220183003/diff/20001/mojo/public/rust/tests/...
mojo/public/rust/tests/util/mojom_validation.rs:361: match
state.decode_struct_header(&StructGVersions) {
On 2016/08/08 20:34:15, Eric Holk wrote:
> You use this pattern a lot, but I think it's basically the try! macro. Would
> that work for you?
> 
> https://doc.rust-lang.org/std/result/index.html#the-try-macro
> 
> Actually, I forgot that this file was generated code, so I wouldn't worry
about
> the try! macro. If you have it outside of here, it will probably make your
code
> a lot cleaner.

Oh, wow, yeah I completely forgot about the try! macro. That makes it so much
cleaner. Thanks!

[mknyszek, 2016-08-08 22:47:25]

https://codereview.chromium.org/2220183003/diff/40001/mojo/public/rust/src/bi...
File mojo/public/rust/src/bindings/run_loop.rs (left):

https://codereview.chromium.org/2220183003/diff/40001/mojo/public/rust/src/bi...
mojo/public/rust/src/bindings/run_loop.rs:207: /// notion of "now".
Oops, this was an accident. Running rustfmt apparently "fixed" the formatting in
the RunLoop implementation. This can be safely ignored, it's just cosmetic.

[mknyszek, 2016-08-09 22:44:59]

Patchset #5 (id:80001) has been deleted

[mknyszek, 2016-08-09 22:45:08]

Patchset #4 (id:60001) has been deleted

[mknyszek, 2016-08-10 17:31:34]

Description was changed from

==========
Rust: Add validation to decode
==========

to

==========
Rust: Add validation checks to decode

In the Rust bindings we now perform validation of the input
buffer on Mojom decode. The generated code checked in for
tests has been updated as well in order to test validation in
nearly all of the cases outlined in the "golden" files.

The only missing tests to run are the integration tests which
are to come in a future CL.
==========

[mknyszek, 2016-08-10 17:33:57]

Description was changed from

==========
Rust: Add validation checks to decode

In the Rust bindings we now perform validation of the input
buffer on Mojom decode. The generated code checked in for
tests has been updated as well in order to test validation in
nearly all of the cases outlined in the "golden" files.

The only missing tests to run are the integration tests which
are to come in a future CL.
==========

to

==========
Rust: Add validation checks to decode

In the Rust bindings we now perform validation of the input
buffer on Mojom decode. The generated code checked in for
tests has been updated as well in order to test validation in
nearly all of the cases outlined in the "golden" files.

The only missing tests to run are the integration tests which
are to come in a future CL.

R=eholk@chromium.org

Committed:
https://chromium.googlesource.com/external/mojo/+/4fbb11a4a65151bbc73545a9f2d...
==========

[mknyszek, 2016-08-10 17:33:58]

Committed patchset #4 (id:100001) manually as
4fbb11a4a65151bbc73545a9f2dbc4627db9d0a0 (presubmit successful).