Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2213563002: Rust: Add encoder/decoder tests (Closed)

Created:
4 years, 4 months ago by mknyszek
Modified:
4 years, 4 months ago
Base URL:
git@github.com:domokit/mojo.git@decoding
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Rust: Add encoder/decoder tests Uses the validation input test parser library in order to automate running tests on "good" inputs to the mojom encoding and decoding frameworks in the Rust bindings. Included is Rust code generated by the Mojom code generator (to be added in a later CL) for validation_test_interfaces.mojom, which is then used in the tests. R=eholk@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/54d9edfd21ecd0b23dda20a7f72f46685c2d476b

Patch Set 1 #

Patch Set 2 : Rebase onto validation data issue #

Patch Set 3 : Add versioning for structs and test it #

Patch Set 4 : Add unknown variant for unions and test it #

Patch Set 5 : Removed duplicate code #

Patch Set 6 : Switch to using fixed arrays #

Patch Set 7 : Propagate decoding/hashmap fix #

Total comments: 1

Patch Set 8 : Update tests to use fixed arrays #

Patch Set 9 : Propagate fix for unsafe unwinding #

Patch Set 10 : Test with changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3380 lines, -1 line) Patch
M mojo/public/rust/build.rs View 1 chunk +8 lines, -1 line 0 comments Download
A mojo/public/rust/tests/encoding.rs View 1 2 3 4 5 6 7 1 chunk +675 lines, -0 lines 0 comments Download
M mojo/public/rust/tests/util/mod.rs View 1 2 3 4 5 6 7 8 9 2 chunks +60 lines, -0 lines 0 comments Download
A mojo/public/rust/tests/util/mojom_validation.rs View 1 2 3 4 5 6 7 1 chunk +2636 lines, -0 lines 0 comments Download
M mojo/rust/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
mknyszek
These are passing tests for the Mojom encoding/decoding framework in Rust based on the "golden" ...
4 years, 4 months ago (2016-08-03 23:27:06 UTC) #2
Eric Holk
lgtm Just to make sure, if you intentionally break something somewhere tests start failing, right? ...
4 years, 4 months ago (2016-08-08 19:52:34 UTC) #3
mknyszek
On 2016/08/08 19:52:34, Eric Holk wrote: > lgtm > > Just to make sure, if ...
4 years, 4 months ago (2016-08-08 21:18:12 UTC) #4
mknyszek
4 years, 4 months ago (2016-08-10 17:27:10 UTC) #7
Message was sent while issue was closed.
Committed patchset #10 (id:180001) manually as
54d9edfd21ecd0b23dda20a7f72f46685c2d476b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698