Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2220133002: Don't restore in LayoutBlock::layout if clamping is delayed. (Closed)

Created:
4 years, 4 months ago by skobes
Modified:
4 years, 4 months ago
Reviewers:
ymalik, szager1
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't restore in LayoutBlock::layout if clamping is delayed. BUG=624534 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/0cd0e9c225f682449743476969ced1ab51e6b1eb Cr-Commit-Position: refs/heads/master@{#412450}

Patch Set 1 #

Total comments: 2

Patch Set 2 : add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -5 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 1 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ScrollAnchorTest.cpp View 1 chunk +31 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
skobes
4 years, 4 months ago (2016-08-17 01:06:57 UTC) #10
szager1
lgtm
4 years, 4 months ago (2016-08-17 01:09:48 UTC) #11
ymalik
lgtm
4 years, 4 months ago (2016-08-17 01:23:22 UTC) #12
ymalik
https://codereview.chromium.org/2220133002/diff/40001/third_party/WebKit/Source/core/layout/LayoutBlock.cpp File third_party/WebKit/Source/core/layout/LayoutBlock.cpp (right): https://codereview.chromium.org/2220133002/diff/40001/third_party/WebKit/Source/core/layout/LayoutBlock.cpp#newcode383 third_party/WebKit/Source/core/layout/LayoutBlock.cpp:383: // If clamping is delayed, we will restore in ...
4 years, 4 months ago (2016-08-17 01:25:28 UTC) #13
skobes
https://codereview.chromium.org/2220133002/diff/40001/third_party/WebKit/Source/core/layout/LayoutBlock.cpp File third_party/WebKit/Source/core/layout/LayoutBlock.cpp (right): https://codereview.chromium.org/2220133002/diff/40001/third_party/WebKit/Source/core/layout/LayoutBlock.cpp#newcode383 third_party/WebKit/Source/core/layout/LayoutBlock.cpp:383: // If clamping is delayed, we will restore in ...
4 years, 4 months ago (2016-08-17 01:27:48 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2220133002/60001
4 years, 4 months ago (2016-08-17 01:28:16 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 4 months ago (2016-08-17 04:40:34 UTC) #19
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 04:42:42 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0cd0e9c225f682449743476969ced1ab51e6b1eb
Cr-Commit-Position: refs/heads/master@{#412450}

Powered by Google App Engine
This is Rietveld 408576698