third_party/WebKit/Source/core/layout/LayoutBlock.cpp - Issue 2220133002: Don't restore in LayoutBlock::layout if clamping is delayed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBlock.cpp

Issue 2220133002: Don't restore in LayoutBlock::layout if clamping is delayed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add comment Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/layout/LayoutBlock.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBlock.cpp b/third_party/WebKit/Source/core/layout/LayoutBlock.cpp

index e9b66e54782fc5b0fd8fcaeb40c89dc67d7cc1cc..2e58ffe80a1474b3360d6243e7b8270edd086158 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBlock.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBlock.cpp

@@ -380,7 +380,10 @@ void LayoutBlock::layout()

invalidateBackgroundObscurationStatus();

- if (needsScrollAnchoring)

+ // If clamping is delayed, we will restore in PaintLayerScrollableArea::clampScrollPositionsAfterLayout.

+ // Restoring during the intermediate layout may clamp the scroller to the wrong bounds.

+ bool clampingDelayed = PaintLayerScrollableArea::DelayScrollPositionClampScope::clampingIsDelayed();

+ if (needsScrollAnchoring && !clampingDelayed)

getScrollableArea()->scrollAnchor().restore();

m_heightAvailableToChildrenChanged = false;

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/ScrollAnchorTest.cpp » ('j') | no next file with comments »