Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ui/android/view_android.cc

Issue 2219823002: Move content offset to ViewAndroid (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« content/browser/android/content_view_core_impl.cc ('K') | « ui/android/view_android.h ('k') | ui/android/window_android.h » ('j') | ui/snapshot/snapshot_android.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/android/view_android.cc
diff --git a/ui/android/view_android.cc b/ui/android/view_android.cc
index 4e969e25a7a314db9bbc462d843e07ff32bb96bd..70d5ee09b66c7635653ada1936ea2f21e6b19820 100644
--- a/ui/android/view_android.cc
+++ b/ui/android/view_android.cc
@@ -127,9 +127,7 @@ void ViewAndroid::SetAnchorRect(const JavaRef<jobject>& anchor,
->GetDisplayNearestWindow(this)
.device_scale_factor();
int left_margin = std::round(bounds.x() * scale);
- // TODO(jinsukkim): Move content_offset() to ViewAndroid, since it's
- // specific to a given web contents/render widget.
- float content_offset_y_pix = GetWindowAndroid()->content_offset().y();
+ float content_offset_y_pix = content_offset().y();
int top_margin = std::round(content_offset_y_pix + bounds.y() * scale);
JNIEnv* env = base::android::AttachCurrentThread();
Java_ViewAndroidDelegate_setViewPosition(env,
« content/browser/android/content_view_core_impl.cc ('K') | « ui/android/view_android.h ('k') | ui/android/window_android.h » ('j') | ui/snapshot/snapshot_android.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698