Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9683)

Unified Diff: content/browser/android/content_view_core_impl.cc

Issue 2219823002: Move content offset to ViewAndroid (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/android/view_android.h » ('j') | ui/snapshot/snapshot_android.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/android/content_view_core_impl.cc
diff --git a/content/browser/android/content_view_core_impl.cc b/content/browser/android/content_view_core_impl.cc
index bee676ccad0a560288c9ea6fa10aa8d949b1b53b..83c38935d9e3593ac633bff7377b510cad1abced 100644
--- a/content/browser/android/content_view_core_impl.cc
+++ b/content/browser/android/content_view_core_impl.cc
@@ -429,8 +429,7 @@ void ContentViewCoreImpl::UpdateFrameInfo(
if (obj.is_null() || !view_.GetWindowAndroid())
return;
- view_.GetWindowAndroid()->set_content_offset(
- gfx::ScaleVector2d(content_offset, dpi_scale_));
+ view_.set_content_offset(gfx::ScaleVector2d(content_offset, dpi_scale_));
no sievers 2016/08/05 18:22:44 Actually with your change this can now be done in
Jinsuk Kim 2016/12/22 12:35:48 Done. BTW I'm not clear about what to do with the
boliu 2016/12/22 21:22:38 Hmm, debatable. Ideally, the offset should be on
page_scale_ = page_scale_factor;
« no previous file with comments | « no previous file | ui/android/view_android.h » ('j') | ui/snapshot/snapshot_android.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698