Move content offset to ViewAndroid

content/browser/android/content_view_core_impl.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/android/content_view_core_impl.h"
 
 #include <stddef.h>
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_array.h"
@@ skipping 411 matching lines @@
     const gfx::SizeF& viewport_size,
     const gfx::Vector2dF& controls_offset,
     const gfx::Vector2dF& content_offset,
     bool is_mobile_optimized_hint,
     const gfx::SelectionBound& selection_start) {
   JNIEnv* env = AttachCurrentThread();
   ScopedJavaLocalRef<jobject> obj = java_ref_.get(env);
   if (obj.is_null() || !view_.GetWindowAndroid())
     return;
 
-  view_.GetWindowAndroid()->set_content_offset(
-      gfx::ScaleVector2d(content_offset, dpi_scale_));
+  view_.set_content_offset(gfx::ScaleVector2d(content_offset, dpi_scale_));

[no sievers, 2016/08/05 18:22:44]

Actually with your change this can now be done in
render_widget_host_view_android.cc instead.

[Jinsuk Kim, 2016/12/22 12:35:48]

Done. BTW I'm not clear about what to do with the content offset of this
view(owned by WebContentsViewAndroid). Shouldn't this be updated in sync with
RWVHA's view content offset?

[boliu, 2016/12/22 21:22:38]

Hmm, debatable.

Ideally, the offset should be on RWHVA only, not WCVA. WCVA should not
contribute to the rendering output (I think?), so no one should try to read from
it should always just delegate to the active RWHVA.

The answer will also depend on how chrome top controls works in the new
ViewAndroid tree world. I'm not sure what the right answer there is.

I think for now, unless there is code that depends on this, let's leave it out
of the WCVA?

 
   page_scale_ = page_scale_factor;
 
   // The CursorAnchorInfo API in Android only supports zero width selection
   // bounds.
   const jboolean has_insertion_marker =
       selection_start.type() == gfx::SelectionBound::CENTER;
   const jboolean is_insertion_marker_visible = selection_start.visible();
   const jfloat insertion_marker_horizontal =
       has_insertion_marker ? selection_start.edge_top().x() : 0.0f;
@@ skipping 1194 matching lines @@
     return ScopedJavaLocalRef<jobject>();
 
   return view->GetJavaObject();
 }
 
 bool RegisterContentViewCore(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
 
 }  // namespace content