Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 2219813002: Revert of ImageCapture: Queue up requests while device not ready (Closed)

Created:
4 years, 4 months ago by Guido Urdaneta
Modified:
4 years, 4 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, phoglund+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, tnakamura+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of ImageCapture: Queue up requests while device not ready (patchset #4 id:380001 of https://codereview.chromium.org/2193213003/ ) Reason for revert: Speculative revert. Suspect of breaking Android Tester bots. Will revert if it doesn't fix it. See https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/35590 https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/30080 https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Tests%20%28dbg%29%20%28K%20Nexus5%29/builds/9093 https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Tests%20%28dbg%29%20%28L%20Nexus9%29/builds/14332 Original issue's description: > ImageCapture: Queue up requests while device not ready > > Calls to ImageCapture methods (e.g. takePhoto(), getPhotoCapabilities()) > might be lost if racing against either: > - device creation (in VideoCaptureManager) > - actual device capture (in VideoCaptureDeviceAndroid) > > So, this CL: > - adds a "queue" of image capture-related requests in > VideoCaptureManager, where we store such requests _if_ the > capture device is not ready (but it's known) -- these are > served OnDeviceStarted(). > > - adds a similar "queue" of requests in VideoCaptureDeviceAndroid, > where we store requests is the device has not captured anything > yet (Android API needs the device up and running for many > operations). > > - adds a takePhoto() content_browsertest for Android and > FakeVideoCaptureDevice, factoring Js code appropriately. > > BUG=518807, 627537 > TEST=added new content_browsertest: > out/gn/bin/run_content_browsertests(_incremental) --gtest_filter=*WebRtcImageCaptureBrowserTest* > or > out/gn/content_browsertests --gtest_filter=*WebRtcImageCaptureBrowserTest* > > Committed: https://crrev.com/bd1933b1b5ee7a3557401fe79f63f38e3d5deb81 > Cr-Commit-Position: refs/heads/master@{#409988} TBR=emircan@chromium.org,nick@chromium.org,mcasas@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=518807, 627537 Committed: https://crrev.com/5baed5f27510f85dc8a44dfd8f0c62f35a5808d7 Cr-Commit-Position: refs/heads/master@{#410023}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+272 lines, -508 lines) Patch
M content/browser/renderer_host/media/video_capture_manager.h View 4 chunks +7 lines, -21 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_manager.cc View 6 chunks +32 lines, -90 lines 0 comments Download
M content/browser/webrtc/webrtc_image_capture_browsertest.cc View 3 chunks +16 lines, -39 lines 0 comments Download
M content/test/data/media/image_capture_test.html View 3 chunks +16 lines, -56 lines 0 comments Download
M media/capture/video/android/video_capture_device_android.h View 4 chunks +8 lines, -24 lines 0 comments Download
M media/capture/video/android/video_capture_device_android.cc View 8 chunks +192 lines, -278 lines 0 comments Download
M media/capture/video/fake_video_capture_device.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Guido Urdaneta
Created Revert of ImageCapture: Queue up requests while device not ready
4 years, 4 months ago (2016-08-05 10:19:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2219813002/1
4 years, 4 months ago (2016-08-05 10:20:05 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-05 10:20:54 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 10:22:02 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5baed5f27510f85dc8a44dfd8f0c62f35a5808d7
Cr-Commit-Position: refs/heads/master@{#410023}

Powered by Google App Engine
This is Rietveld 408576698