Chromium Code Reviews
DescriptionRevert of ImageCapture: Queue up requests while device not ready (patchset #4 id:380001 of https://codereview.chromium.org/2193213003/ )
Reason for revert:
Speculative revert. Suspect of breaking Android Tester bots.
Will revert if it doesn't fix it.
See https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/35590
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/30080
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Tests%20%28dbg%29%20%28K%20Nexus5%29/builds/9093
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Tests%20%28dbg%29%20%28L%20Nexus9%29/builds/14332
Original issue's description:
> ImageCapture: Queue up requests while device not ready
>
> Calls to ImageCapture methods (e.g. takePhoto(), getPhotoCapabilities())
> might be lost if racing against either:
> - device creation (in VideoCaptureManager)
> - actual device capture (in VideoCaptureDeviceAndroid)
>
> So, this CL:
> - adds a "queue" of image capture-related requests in
> VideoCaptureManager, where we store such requests _if_ the
> capture device is not ready (but it's known) -- these are
> served OnDeviceStarted().
>
> - adds a similar "queue" of requests in VideoCaptureDeviceAndroid,
> where we store requests is the device has not captured anything
> yet (Android API needs the device up and running for many
> operations).
>
> - adds a takePhoto() content_browsertest for Android and
> FakeVideoCaptureDevice, factoring Js code appropriately.
>
> BUG=518807, 627537
> TEST=added new content_browsertest:
> out/gn/bin/run_content_browsertests(_incremental) --gtest_filter=*WebRtcImageCaptureBrowserTest*
> or
> out/gn/content_browsertests --gtest_filter=*WebRtcImageCaptureBrowserTest*
>
> Committed: https://crrev.com/bd1933b1b5ee7a3557401fe79f63f38e3d5deb81
> Cr-Commit-Position: refs/heads/master@{#409988}
TBR=emircan@chromium.org,nick@chromium.org,mcasas@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=518807, 627537
Committed: https://crrev.com/5baed5f27510f85dc8a44dfd8f0c62f35a5808d7
Cr-Commit-Position: refs/heads/master@{#410023}
Patch Set 1 #
Messages
Total messages: 7 (3 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||