Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1302)

Unified Diff: content/browser/webrtc/webrtc_image_capture_browsertest.cc

Issue 2219813002: Revert of ImageCapture: Queue up requests while device not ready (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/webrtc/webrtc_image_capture_browsertest.cc
diff --git a/content/browser/webrtc/webrtc_image_capture_browsertest.cc b/content/browser/webrtc/webrtc_image_capture_browsertest.cc
index 19ffda4fe504877b185ab504f6a41e3f2622b639..3c8303b30d27f86774aacb26cb58b1b5b15328af 100644
--- a/content/browser/webrtc/webrtc_image_capture_browsertest.cc
+++ b/content/browser/webrtc/webrtc_image_capture_browsertest.cc
@@ -20,26 +20,29 @@
// platforms where the ImageCaptureCode is landed, https://crbug.com/518807.
static struct TargetCamera {
bool use_fake;
-}
-#if defined(OS_ANDROID)
-const kTestParameters[] = {{true}, {false}};
-#else
-const kTestParameters[] = {{true}};
-#endif
+} const kTestParameters[] = {{true}};
} // namespace
namespace content {
+#if defined(OS_WIN)
+// This test is flaky on WebRTC Windows bots: https://crbug.com/633242.
+#define MAYBE_WebRtcImageCaptureBrowserTest \
+ DISABLED_WebRtcImageCaptureBrowserTest
+#else
+#define MAYBE_WebRtcImageCaptureBrowserTest WebRtcImageCaptureBrowserTest
+#endif
+
// This class is the content_browsertests for Image Capture API, which allows
// for capturing still images out of a MediaStreamTrack. Is a
// WebRtcWebcamBrowserTest to be able to use a physical camera.
-class WebRtcImageCaptureBrowserTest
+class MAYBE_WebRtcImageCaptureBrowserTest
: public WebRtcWebcamBrowserTest,
public testing::WithParamInterface<struct TargetCamera> {
public:
- WebRtcImageCaptureBrowserTest() = default;
- ~WebRtcImageCaptureBrowserTest() override = default;
+ MAYBE_WebRtcImageCaptureBrowserTest() = default;
+ ~MAYBE_WebRtcImageCaptureBrowserTest() override = default;
void SetUpCommandLine(base::CommandLine* command_line) override {
WebRtcWebcamBrowserTest::SetUpCommandLine(command_line);
@@ -65,17 +68,11 @@
}
private:
- DISALLOW_COPY_AND_ASSIGN(WebRtcImageCaptureBrowserTest);
+ DISALLOW_COPY_AND_ASSIGN(MAYBE_WebRtcImageCaptureBrowserTest);
};
-#if defined(OS_WIN)
-// This test is flaky on WebRTC Windows bots: https://crbug.com/633242.
-#define MAYBE_CreateAndGetCapabilities DISABLED_CreateAndGetCapabilities
-#else
-#define MAYBE_CreateAndGetCapabilities CreateAndGetCapabilities
-#endif
-IN_PROC_BROWSER_TEST_P(WebRtcImageCaptureBrowserTest,
- MAYBE_CreateAndGetCapabilities) {
+IN_PROC_BROWSER_TEST_P(MAYBE_WebRtcImageCaptureBrowserTest,
+ CreateAndGetCapabilities) {
ASSERT_TRUE(embedded_test_server()->Start());
GURL url(embedded_test_server()->GetURL(kImageCaptureHtmlFile));
NavigateToURL(shell(), url);
@@ -88,28 +85,8 @@
FAIL();
}
-#if defined(OS_WIN)
-// This test is flaky on WebRTC Windows bots: https://crbug.com/633242.
-#define MAYBE_CreateAndTakePhoto DISABLED_CreateAndTakePhoto
-#else
-#define MAYBE_CreateAndTakePhoto CreateAndTakePhoto
-#endif
-IN_PROC_BROWSER_TEST_P(WebRtcImageCaptureBrowserTest,
- MAYBE_CreateAndTakePhoto) {
- ASSERT_TRUE(embedded_test_server()->Start());
- GURL url(embedded_test_server()->GetURL(kImageCaptureHtmlFile));
- NavigateToURL(shell(), url);
-
- std::string result;
- ASSERT_TRUE(ExecuteScriptAndExtractString(shell(), "testCreateAndTakePhoto()",
- &result));
- if (result == "OK")
- return;
- FAIL();
-}
-
INSTANTIATE_TEST_CASE_P(,
- WebRtcImageCaptureBrowserTest,
+ MAYBE_WebRtcImageCaptureBrowserTest,
testing::ValuesIn(kTestParameters));
} // namespace content
« no previous file with comments | « content/browser/renderer_host/media/video_capture_manager.cc ('k') | content/test/data/media/image_capture_test.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698