SkPDF: Stop using kHAdvance_PerGlyphInfo

SkPDF: Stop using kHAdvance_PerGlyphInfo

SkPDFFont:
- never request kHAdvance_PerGlyphInfo from typeface.
- set_glyph_widths() fn uses a glyph cache to get advances.
- stop expecting vertical advances that are never requested.
- composeAdvanceData() now non-templated
- appendAdvance() one-line function removed

SkPDFDevice:
- use a glyph cache for getting repeated advances.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2219733004

Committed: https://skia.googlesource.com/skia/+/462d0148a5c9433a1f9c26d947a07ca7f70cf09d

[hal.canary, 2016-08-05 18:54:14]

Description was changed from

==========
SkPDF: Stop using kHAdvance_PerGlyphInfo

SkPDFFont:
- never request kHAdvance_PerGlyphInfo from typeface.
- set_glyph_widths() fn uses a glyph cache to get advances.
- stop expecting vertical advances that are never requested.
- composeAdvanceData() now non-templated
- appendAdvance() one-line function removed

SkPDFDevice:
- use a glyph cache for getting repeated advances.
==========

to

==========
SkPDF: Stop using kHAdvance_PerGlyphInfo

SkPDFFont:
- never request kHAdvance_PerGlyphInfo from typeface.
- set_glyph_widths() fn uses a glyph cache to get advances.
- stop expecting vertical advances that are never requested.
- composeAdvanceData() now non-templated
- appendAdvance() one-line function removed

SkPDFDevice:
- use a glyph cache for getting repeated advances.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2219733004
==========

[hal.canary, 2016-08-05 18:54:30]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 18:54:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hal.canary, 2016-08-05 18:54:40]

halcanary@google.com changed reviewers:
+ bungeman@google.com

[hal.canary, 2016-08-05 18:54:41]

PTAL

[commit-bot: I haz the power, 2016-08-05 19:03:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 19:03:35]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-GN-Trybot on master.client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[bungeman-skia, 2016-08-05 19:08:01]

https://codereview.chromium.org/2219733004/diff/1/src/pdf/SkPDFDevice.cpp
File src/pdf/SkPDFDevice.cpp (right):

https://codereview.chromium.org/2219733004/diff/1/src/pdf/SkPDFDevice.cpp#new...
src/pdf/SkPDFDevice.cpp:1284: SkScalar advanceWidth =
autoGlyphCache->getGlyphIDAdvance(encodedValue).fAdvanceX;
Is there a reason to put this declaration up here instead of down where it used
to be? There doesn't appear to be a good reason to do this work until after the
following 'if' block.

[hal.canary, 2016-08-05 19:42:37]

https://codereview.chromium.org/2219733004/diff/1/src/pdf/SkPDFDevice.cpp
File src/pdf/SkPDFDevice.cpp (right):

https://codereview.chromium.org/2219733004/diff/1/src/pdf/SkPDFDevice.cpp#new...
src/pdf/SkPDFDevice.cpp:1284: SkScalar advanceWidth =
autoGlyphCache->getGlyphIDAdvance(encodedValue).fAdvanceX;
On 2016/08/05 19:08:01, bungeman-skia wrote:
> Is there a reason to put this declaration up here instead of down where it
used
> to be? There doesn't appear to be a good reason to do this work until after
the
> following 'if' block.

I realized that this could give wrong results if glyphsToPDFFontEncoding
multates the value of encodedValue.

[hal.canary, 2016-08-05 19:42:45]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 19:42:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 20:06:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 20:06:18]

Dry run: This issue passed the CQ dry run.

[bungeman-skia, 2016-08-05 20:09:54]

lgtm with nit

https://codereview.chromium.org/2219733004/diff/20001/src/pdf/SkPDFFont.cpp
File src/pdf/SkPDFFont.cpp (right):

https://codereview.chromium.org/2219733004/diff/20001/src/pdf/SkPDFFont.cpp#n...
src/pdf/SkPDFFont.cpp:1068: // Generate glyph id array.
nit: indent

[hal.canary, 2016-08-05 20:11:34]

The CQ bit was checked by halcanary@google.com

[hal.canary, 2016-08-05 20:11:34]

The patchset sent to the CQ was uploaded after l-g-t-m from bungeman@google.com
Link to the patchset: https://codereview.chromium.org/2219733004/#ps40001
(title: "2016-08-05 (Friday) 16:11:24 EDT")

[commit-bot: I haz the power, 2016-08-05 20:11:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 20:51:49]

Description was changed from

==========
SkPDF: Stop using kHAdvance_PerGlyphInfo

SkPDFFont:
- never request kHAdvance_PerGlyphInfo from typeface.
- set_glyph_widths() fn uses a glyph cache to get advances.
- stop expecting vertical advances that are never requested.
- composeAdvanceData() now non-templated
- appendAdvance() one-line function removed

SkPDFDevice:
- use a glyph cache for getting repeated advances.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2219733004
==========

to

==========
SkPDF: Stop using kHAdvance_PerGlyphInfo

SkPDFFont:
- never request kHAdvance_PerGlyphInfo from typeface.
- set_glyph_widths() fn uses a glyph cache to get advances.
- stop expecting vertical advances that are never requested.
- composeAdvanceData() now non-templated
- appendAdvance() one-line function removed

SkPDFDevice:
- use a glyph cache for getting repeated advances.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2219733004

Committed:
https://skia.googlesource.com/skia/+/462d0148a5c9433a1f9c26d947a07ca7f70cf09d
==========

[commit-bot: I haz the power, 2016-08-05 20:51:50]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/462d0148a5c9433a1f9c26d947a07ca7f70cf09d