src/core/SkAdvancedTypefaceMetrics.cpp - Issue 2219733004: SkPDF: Stop using kHAdvance_PerGlyphInfo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkAdvancedTypefaceMetrics.cpp

Issue 2219733004: SkPDF: Stop using kHAdvance_PerGlyphInfo (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: 2016-08-05 (Friday) 16:11:24 EDT Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkAdvancedTypefaceMetrics.cpp

diff --git a/src/core/SkAdvancedTypefaceMetrics.cpp b/src/core/SkAdvancedTypefaceMetrics.cpp

index ae8fc861c38806c6918eaeb152abcf9f91c3ab3a..bddd91260c460dcd8013b36cafd2a0de50d0ce86 100644

--- a/src/core/SkAdvancedTypefaceMetrics.cpp

+++ b/src/core/SkAdvancedTypefaceMetrics.cpp

@@ -182,7 +182,6 @@ void SkAdvancedTypefaceMetrics::setGlyphWidths(

}

if (curRange.fStartId == lastIndex) {

- SkASSERT(prevRange);

if (!prevRange) {

fGlyphWidths.reset();

return; // https://crbug.com/567031

« no previous file with comments | « no previous file | src/pdf/SkPDFDevice.cpp » ('j') | no next file with comments »