Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 221973003: Pepper: Change uma presubmit to never block CQ. (Closed)

Created:
6 years, 8 months ago by teravest
Modified:
6 years, 8 months ago
Reviewers:
xhwang
CC:
chromium-reviews
Visibility:
Public.

Description

Pepper: Change uma presubmit to never block CQ. This changes the presubmit rule for adding pepper interface hashes to UMA to a notification instead of a warning. This is because the presubmit is a bit too broad, and was blocking some changes from being submitted through the CQ. Using a notification message should be fine, since the impact of missing a histogram is relatively low (we'll just see a number for a while), and the hash can always be added later. BUG=351389 R=xhwang@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261411

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ppapi/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
teravest
6 years, 8 months ago (2014-04-02 16:15:06 UTC) #1
xhwang
lgtm, thanks!
6 years, 8 months ago (2014-04-02 16:53:07 UTC) #2
teravest
The CQ bit was checked by teravest@chromium.org
6 years, 8 months ago (2014-04-02 16:54:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/221973003/1
6 years, 8 months ago (2014-04-02 16:55:18 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 02:09:38 UTC) #5
commit-bot: I haz the power
Retried try job too often on android_aosp for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_aosp&number=61273
6 years, 8 months ago (2014-04-03 02:09:38 UTC) #6
teravest
The CQ bit was checked by teravest@chromium.org
6 years, 8 months ago (2014-04-03 14:18:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/221973003/1
6 years, 8 months ago (2014-04-03 14:19:24 UTC) #8
teravest
6 years, 8 months ago (2014-04-03 15:36:48 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 manually as r261411 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698