ppapi/PRESUBMIT.py - Issue 221973003: Pepper: Change uma presubmit to never block CQ.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/PRESUBMIT.py

Issue 221973003: Pepper: Change uma presubmit to never block CQ. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ppapi/PRESUBMIT.py

diff --git a/ppapi/PRESUBMIT.py b/ppapi/PRESUBMIT.py

index 4a71f49574c105c16638ff3ce34a6f681119555c..2d83ef87922f2f5d0cfe2d8412ab332d6c72e162 100644

--- a/ppapi/PRESUBMIT.py

+++ b/ppapi/PRESUBMIT.py

@@ -172,7 +172,7 @@ def CheckHistogramXml(input_api, output_api):

has_histogram_xml_change = True

if interface_changes and not has_histogram_xml_change:

- return [output_api.PresubmitPromptWarning(

+ return [output_api.PresubmitNotifyResult(

'Missing change to tools/metrics/histograms/histograms.xml.\n' +

'Run pepper_hash_for_uma to make get values for new interfaces.\n' +

'Interface changes:\n' + '\n'.join(interface_changes))]

« no previous file with comments | « no previous file | no next file » | no next file with comments »