Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2219653003: Removing old recipe code (Closed)

Created:
4 years, 4 months ago by martiniss
Modified:
4 years, 4 months ago
Reviewers:
estaab, iannucci
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -736 lines) Patch
D scripts/slave/recipe_modules/recipe_autoroller/__init__.py View 1 chunk +0 lines, -15 lines 0 comments Download
D scripts/slave/recipe_modules/recipe_autoroller/api.py View 1 chunk +0 lines, -288 lines 0 comments Download
D scripts/slave/recipe_modules/recipe_autoroller/test_api.py View 1 chunk +0 lines, -71 lines 0 comments Download
D scripts/slave/recipe_modules/recipe_tryjob/__init__.py View 1 chunk +0 lines, -12 lines 0 comments Download
D scripts/slave/recipe_modules/recipe_tryjob/api.py View 1 chunk +0 lines, -321 lines 0 comments Download
D scripts/slave/recipe_modules/recipe_tryjob/test_api.py View 1 chunk +0 lines, -29 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
martiniss
PTAL
4 years, 4 months ago (2016-08-05 02:42:46 UTC) #2
estaab
lgtm
4 years, 4 months ago (2016-08-05 02:44:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2219653003/1
4 years, 4 months ago (2016-08-05 03:49:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/bb625f1644801a28def48c7118a9753685d1e45c
4 years, 4 months ago (2016-08-05 03:54:39 UTC) #7
martiniss
4 years, 4 months ago (2016-08-05 17:17:29 UTC) #8
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2214303003/ by martiniss@chromium.org.

The reason for reverting is: Broke internal tryjob still :(.

Powered by Google App Engine
This is Rietveld 408576698