Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2214303003: Revert of Removing old recipe code (Closed)

Created:
4 years, 4 months ago by martiniss
Modified:
4 years, 4 months ago
Reviewers:
estaab, iannucci
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of Removing old recipe code (patchset #1 id:1 of https://codereview.chromium.org/2219653003/ ) Reason for revert: Broke internal tryjob still :( Original issue's description: > Removing old recipe code > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/bb625f1644801a28def48c7118a9753685d1e45c TBR=estaab@chromium.org,iannucci@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://chromium.googlesource.com/chromium/tools/build/+/ef300a91ffa556e0b7eeed363b926aeea9eb3a40

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+736 lines, -0 lines) Patch
A scripts/slave/recipe_modules/recipe_autoroller/__init__.py View 1 chunk +15 lines, -0 lines 0 comments Download
A scripts/slave/recipe_modules/recipe_autoroller/api.py View 1 chunk +288 lines, -0 lines 0 comments Download
A scripts/slave/recipe_modules/recipe_autoroller/test_api.py View 1 chunk +71 lines, -0 lines 0 comments Download
A scripts/slave/recipe_modules/recipe_tryjob/__init__.py View 1 chunk +12 lines, -0 lines 0 comments Download
A scripts/slave/recipe_modules/recipe_tryjob/api.py View 1 chunk +321 lines, -0 lines 0 comments Download
A scripts/slave/recipe_modules/recipe_tryjob/test_api.py View 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
martiniss
Created Revert of Removing old recipe code
4 years, 4 months ago (2016-08-05 17:17:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2214303003/1
4 years, 4 months ago (2016-08-05 17:17:34 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/ef300a91ffa556e0b7eeed363b926aeea9eb3a40
4 years, 4 months ago (2016-08-05 17:17:43 UTC) #5
martiniss
4 years, 4 months ago (2016-08-12 20:09:47 UTC) #6
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2240303002/ by martiniss@chromium.org.

The reason for reverting is: Internal code removed..

Powered by Google App Engine
This is Rietveld 408576698