third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp - Issue 2219393003: DevTools: Runtime.compileScript with persistScript = false should not report script

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp

Issue 2219393003: DevTools: Runtime.compileScript with persistScript = false should not report script (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp ('K') | « third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp

index cf2c2ba82e78c37f908e18bc1283ad9a97fd7e2d..fe7557d0b949148d937b87fc663c00f9bf9a1b2a 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp

@@ -37,6 +37,7 @@

#include "platform/v8_inspector/RemoteObjectId.h"

#include "platform/v8_inspector/V8ConsoleMessage.h"

#include "platform/v8_inspector/V8Debugger.h"

+#include "platform/v8_inspector/V8DebuggerAgentImpl.h"

#include "platform/v8_inspector/V8InspectorImpl.h"

#include "platform/v8_inspector/V8InspectorSessionImpl.h"

#include "platform/v8_inspector/V8StackTraceImpl.h"

@@ -503,7 +504,12 @@ void V8RuntimeAgentImpl::compileScript(ErrorString* errorString,

if (!scope.initialize())

return;

+ V8DebuggerAgentImpl* debuggerAgent = m_session->debuggerAgent();

+ if (!persistScript)

+ debuggerAgent->setIgnoreScriptParsedEvents(true);

v8::Local<v8::Script> script = m_inspector->compileScript(scope.context(), toV8String(m_inspector->isolate(), expression), sourceURL, false);

+ if (!persistScript)

+ debuggerAgent->setIgnoreScriptParsedEvents(false);

if (script.IsEmpty()) {

v8::Local<v8::Message> message = scope.tryCatch().Message();

if (!message.IsEmpty())