Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1485)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp

Issue 2219393003: DevTools: Runtime.compileScript with persistScript = false should not report script (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
index 584c0164e0339ae5b3d39bc8d4e9001d6f6e7a8f..b13c5b83076a059639c46b39467e88d911ee0692 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
@@ -113,6 +113,7 @@ V8DebuggerAgentImpl::V8DebuggerAgentImpl(V8InspectorSessionImpl* session, protoc
, m_recursionLevelForStepOut(0)
, m_recursionLevelForStepFrame(0)
, m_skipAllPauses(false)
+ , m_ignoreScriptParsedEvents(false)
{
clearBreakDetails();
}
@@ -994,6 +995,8 @@ std::unique_ptr<StackTrace> V8DebuggerAgentImpl::currentAsyncStackTrace()
void V8DebuggerAgentImpl::didParseSource(std::unique_ptr<V8DebuggerScript> script, bool success)
{
+ if (m_ignoreScriptParsedEvents)
+ return;
v8::HandleScope handles(m_isolate);
String16 scriptSource = toProtocolString(script->source(m_isolate));
bool isDeprecatedSourceURL = false;
@@ -1164,6 +1167,11 @@ void V8DebuggerAgentImpl::breakProgramOnException(const String16& breakReason, s
breakProgram(breakReason, std::move(data));
}
+void V8DebuggerAgentImpl::setIgnoreScriptParsedEvents(bool ignore)
kozy 2016/08/09 16:25:44 Can we ignore this events in V8Debugger because V8
lushnikov 2016/08/09 20:16:13 Done.
+{
+ m_ignoreScriptParsedEvents = ignore;
+}
+
bool V8DebuggerAgentImpl::assertPaused(ErrorString* errorString)
{
if (m_pausedContext.IsEmpty()) {

Powered by Google App Engine
This is Rietveld 408576698