third_party/WebKit/LayoutTests/webshare/share-types.html - Issue 2219383002: Require a user gesture to use navigator.share.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/webshare/share-types.html

Issue 2219383002: Require a user gesture to use navigator.share. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@webshare-dictionary

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/webshare/share-success.html ('k') | third_party/WebKit/LayoutTests/webshare/share-without-user-gesture.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/webshare/share-types.html

diff --git a/third_party/WebKit/LayoutTests/webshare/share-types.html b/third_party/WebKit/LayoutTests/webshare/share-types.html

index 8c49cb15e791475b45ec2bcf16182dce7e2fb79b..64d8229b038da564cf9dba6c279176fc4c06eb18 100644

--- a/third_party/WebKit/LayoutTests/webshare/share-types.html

+++ b/third_party/WebKit/LayoutTests/webshare/share-types.html

@@ -7,7 +7,7 @@

share_test((t, mock) => {

mock.pushShareResult('384957', '[object Object]', null);

- return navigator.share({title: 384957, text: {}});

+ return callWithKeyDown(() => navigator.share({title: 384957, text: {}}));

}, 'share of types other than string (expect implicitly converted to string)');

</script>