third_party/WebKit/LayoutTests/webshare/share-success.html - Issue 2219383002: Require a user gesture to use navigator.share.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/webshare/share-success.html

Issue 2219383002: Require a user gesture to use navigator.share. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@webshare-dictionary

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/webshare/share-error.html ('k') | third_party/WebKit/LayoutTests/webshare/share-types.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/webshare/share-success.html

diff --git a/third_party/WebKit/LayoutTests/webshare/share-success.html b/third_party/WebKit/LayoutTests/webshare/share-success.html

index 770b349ffa76833fc9f51c36c59ecf8ad541d110..79000b50d59d01e1b93824c30c280c8dd931d28c 100644

--- a/third_party/WebKit/LayoutTests/webshare/share-success.html

+++ b/third_party/WebKit/LayoutTests/webshare/share-success.html

@@ -7,13 +7,13 @@

share_test((t, mock) => {

mock.pushShareResult('the title', 'the message', null);

- return navigator.share({title: 'the title', text: 'the message',

- url: 'the URL'});

+ return callWithKeyDown(() => navigator.share(

+ {title: 'the title', text: 'the message', url: 'the URL'}));

}, 'successful share');

share_test((t, mock) => {

mock.pushShareResult('', '', null);

- return navigator.share({});

+ return callWithKeyDown(() => navigator.share({}));

}, 'successful share with empty ShareData');

</script>