Always enable intermediate source_set.

Always enable intermediate source_set.

The _use_intermediate_source_set variable was there to workaround a
bug in scoped_nsobject_unittest{,_arc}.mm that was exhibited by the
introduction of an intermediate source_set. Remove the variable and
consider that it is always set to "true".

BUG=637065
Committed: https://crrev.com/40865bdc7372f779689422a0c36cf8073d050366
Cr-Commit-Position: refs/heads/master@{#411779}

[sdefresne, 2016-08-11 22:35:15]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-11 22:36:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2016-08-11 22:36:49]

sdefresne@chromium.org changed reviewers:
+ dpranke@chromium.org

[sdefresne, 2016-08-11 22:36:50]

Please take a look.

[commit-bot: I haz the power, 2016-08-11 22:41:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 22:41:10]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Dirk Pranke, 2016-08-11 22:58:20]

lgtm

[sdefresne, 2016-08-12 19:45:07]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2016-08-12 19:45:07]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2245513002/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2016-08-12 19:45:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 21:30:55]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-12 21:32:13]

Description was changed from

==========
Always enable intermediate source_set.

The _use_intermediate_source_set variable was there to workaround a
bug in scoped_nsobject_unittest{,_arc}.mm that was exhibited by the
introduction of an intermediate source_set. Remove the variable and
consider that it is always set to "true".

BUG=637065
==========

to

==========
Always enable intermediate source_set.

The _use_intermediate_source_set variable was there to workaround a
bug in scoped_nsobject_unittest{,_arc}.mm that was exhibited by the
introduction of an intermediate source_set. Remove the variable and
consider that it is always set to "true".

BUG=637065

Committed: https://crrev.com/40865bdc7372f779689422a0c36cf8073d050366
Cr-Commit-Position: refs/heads/master@{#411779}
==========

[commit-bot: I haz the power, 2016-08-12 21:32:14]

Patchset 2 (id:??) landed as
https://crrev.com/40865bdc7372f779689422a0c36cf8073d050366
Cr-Commit-Position: refs/heads/master@{#411779}

[justincohen, 2016-08-13 03:59:09]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2245903002/ by justincohen@chromium.org.

The reason for reverting is: This is breaking earl grey tests downstream.  I
wonder why upstream eg tests aren't on the cq?

Before:
          cmd LC_ID_DYLIB
      cmdsize 64
         name @rpath/EarlGrey.framework/EarlGrey (offset 24)
After:
          cmd LC_ID_DYLIB
      cmdsize 72
         name obj/ios/third_party/earl_grey/x64/EarlGrey (offset 24).