src/heap-snapshot-generator.cc - Issue 221923006: Mark link between (Detached DOM Trees) and Detached DOM Tree as weak.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap-snapshot-generator.cc

Issue 221923006: Mark link between (Detached DOM Trees) and Detached DOM Tree as weak. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/heap-snapshot-generator.cc

diff --git a/src/heap-snapshot-generator.cc b/src/heap-snapshot-generator.cc

index 332d0dbf6ff3705318f28a666d7134667e12295c..77a557bb25acab99a056df226f1f911c9430e3ba 100644

--- a/src/heap-snapshot-generator.cc

+++ b/src/heap-snapshot-generator.cc

@@ -2408,7 +2408,7 @@ void NativeObjectsExplorer::SetNativeRootReference(

HeapEntry* group_entry =

filler_->FindOrAddEntry(group_info, synthetic_entries_allocator_);

filler_->SetNamedAutoIndexReference(

- HeapGraphEdge::kInternal,

+ HeapGraphEdge::kWeak,

alph 2014/04/02 14:19:09 May be shortcut?

group_entry->index(),

child_entry);

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »