Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Side by Side Diff: src/heap-snapshot-generator.cc

Issue 221923006: Mark link between (Detached DOM Trees) and Detached DOM Tree as weak. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2390 matching lines...) Expand 10 before | Expand all | Expand 10 after
2401 void NativeObjectsExplorer::SetNativeRootReference( 2401 void NativeObjectsExplorer::SetNativeRootReference(
2402 v8::RetainedObjectInfo* info) { 2402 v8::RetainedObjectInfo* info) {
2403 HeapEntry* child_entry = 2403 HeapEntry* child_entry =
2404 filler_->FindOrAddEntry(info, native_entries_allocator_); 2404 filler_->FindOrAddEntry(info, native_entries_allocator_);
2405 ASSERT(child_entry != NULL); 2405 ASSERT(child_entry != NULL);
2406 NativeGroupRetainedObjectInfo* group_info = 2406 NativeGroupRetainedObjectInfo* group_info =
2407 FindOrAddGroupInfo(info->GetGroupLabel()); 2407 FindOrAddGroupInfo(info->GetGroupLabel());
2408 HeapEntry* group_entry = 2408 HeapEntry* group_entry =
2409 filler_->FindOrAddEntry(group_info, synthetic_entries_allocator_); 2409 filler_->FindOrAddEntry(group_info, synthetic_entries_allocator_);
2410 filler_->SetNamedAutoIndexReference( 2410 filler_->SetNamedAutoIndexReference(
2411 HeapGraphEdge::kInternal, 2411 HeapGraphEdge::kWeak,
alph 2014/04/02 14:19:09 May be shortcut?
2412 group_entry->index(), 2412 group_entry->index(),
2413 child_entry); 2413 child_entry);
2414 } 2414 }
2415 2415
2416 2416
2417 void NativeObjectsExplorer::SetWrapperNativeReferences( 2417 void NativeObjectsExplorer::SetWrapperNativeReferences(
2418 HeapObject* wrapper, v8::RetainedObjectInfo* info) { 2418 HeapObject* wrapper, v8::RetainedObjectInfo* info) {
2419 HeapEntry* wrapper_entry = filler_->FindEntry(wrapper); 2419 HeapEntry* wrapper_entry = filler_->FindEntry(wrapper);
2420 ASSERT(wrapper_entry != NULL); 2420 ASSERT(wrapper_entry != NULL);
2421 HeapEntry* info_entry = 2421 HeapEntry* info_entry =
(...skipping 654 matching lines...) Expand 10 before | Expand all | Expand 10 after
3076 writer_->AddString("\"<dummy>\""); 3076 writer_->AddString("\"<dummy>\"");
3077 for (int i = 1; i < sorted_strings.length(); ++i) { 3077 for (int i = 1; i < sorted_strings.length(); ++i) {
3078 writer_->AddCharacter(','); 3078 writer_->AddCharacter(',');
3079 SerializeString(sorted_strings[i]); 3079 SerializeString(sorted_strings[i]);
3080 if (writer_->aborted()) return; 3080 if (writer_->aborted()) return;
3081 } 3081 }
3082 } 3082 }
3083 3083
3084 3084
3085 } } // namespace v8::internal 3085 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698