Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 221923003: DevTools: Add executionContextId in ConsoleMessage in backend (Closed)

Created:
6 years, 8 months ago by sergeyv
Modified:
6 years, 8 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

DevTools: Add executionContextId in ConsoleMessage in backend BUG= R=pfeldman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170664

Patch Set 1 #

Patch Set 2 : Fix compilation on linux bots #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -4 lines) Patch
M Source/core/inspector/ConsoleMessage.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/inspector/ConsoleMessage.cpp View 1 6 chunks +9 lines, -0 lines 0 comments Download
M Source/devtools/front_end/ConsoleModel.js View 4 chunks +7 lines, -3 lines 0 comments Download
M Source/devtools/protocol.json View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
sergeyv
6 years, 8 months ago (2014-04-02 12:34:39 UTC) #1
pfeldman
lgtm
6 years, 8 months ago (2014-04-02 14:01:29 UTC) #2
sergeyv
The CQ bit was checked by sergeyv@chromium.org
6 years, 8 months ago (2014-04-02 14:02:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyv@chromium.org/221923003/1
6 years, 8 months ago (2014-04-02 14:02:29 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-02 14:47:51 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 8 months ago (2014-04-02 14:47:51 UTC) #6
sergeyv
The CQ bit was checked by sergeyv@chromium.org
6 years, 8 months ago (2014-04-02 15:04:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyv@chromium.org/221923003/20001
6 years, 8 months ago (2014-04-02 15:04:11 UTC) #8
sergeyv
6 years, 8 months ago (2014-04-02 15:47:25 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 manually as r170664 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698