Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1623)

Unified Diff: Source/devtools/front_end/ConsoleModel.js

Issue 221923003: DevTools: Add executionContextId in ConsoleMessage in backend (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix compilation on linux bots Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/ConsoleMessage.cpp ('k') | Source/devtools/protocol.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/ConsoleModel.js
diff --git a/Source/devtools/front_end/ConsoleModel.js b/Source/devtools/front_end/ConsoleModel.js
index c396d81f2fde50447bc98e9855ce7325155eae7a..a19659a3dabf9a05efb7d2589c13b0e9d0e788ca 100644
--- a/Source/devtools/front_end/ConsoleModel.js
+++ b/Source/devtools/front_end/ConsoleModel.js
@@ -208,9 +208,10 @@ WebInspector.ConsoleModel.prototype = {
* @param {!Array.<!ConsoleAgent.CallFrame>=} stackTrace
* @param {number=} timestamp
* @param {boolean=} isOutdated
+ * @param {!RuntimeAgent.ExecutionContextId=} executionContextId
*/
-WebInspector.ConsoleMessage = function(source, level, messageText, type, url, line, column, requestId, parameters, stackTrace, timestamp, isOutdated)
+WebInspector.ConsoleMessage = function(source, level, messageText, type, url, line, column, requestId, parameters, stackTrace, timestamp, isOutdated, executionContextId)
{
this.source = source;
this.level = level;
@@ -223,6 +224,7 @@ WebInspector.ConsoleMessage = function(source, level, messageText, type, url, li
this.stackTrace = stackTrace;
this.timestamp = timestamp || Date.now();
this.isOutdated = isOutdated;
+ this.executionContextId = executionContextId;
this.request = requestId ? WebInspector.networkLog.requestForId(requestId) : null;
}
@@ -264,7 +266,8 @@ WebInspector.ConsoleMessage.prototype = {
this.parameters,
this.stackTrace,
this.timestamp,
- this.isOutdated);
+ this.isOutdated,
+ this.executionContextId);
},
/**
@@ -387,7 +390,8 @@ WebInspector.ConsoleDispatcher.prototype = {
payload.parameters,
payload.stackTrace,
payload.timestamp * 1000, // Convert to ms.
- this._console._enablingConsole);
+ this._console._enablingConsole,
+ payload.executionContextId);
this._console.addMessage(consoleMessage, true);
},
« no previous file with comments | « Source/core/inspector/ConsoleMessage.cpp ('k') | Source/devtools/protocol.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698