Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3031)

Unified Diff: chrome/browser/resources/apps_debugger/js/items_list.js

Issue 22191003: [Apps Developer Tool] Show installation warnings as chrome://extensions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/apps_debugger/js/items_list.js
diff --git a/chrome/browser/resources/apps_debugger/js/items_list.js b/chrome/browser/resources/apps_debugger/js/items_list.js
index 999ef37d273e8faaae35901cfa64867c6500a974..5c735149b943c0a16cb6c24eb8ba250b2e4bb4d4 100644
--- a/chrome/browser/resources/apps_debugger/js/items_list.js
+++ b/chrome/browser/resources/apps_debugger/js/items_list.js
@@ -280,6 +280,18 @@ cr.define('apps_dev_tool', function() {
if (!item.may_disable)
node.querySelector('.managed-message').hidden = false;
+ // The install warnings.
+ if (item.install_warnings) {
+ var panel = node.querySelector('.install-warnings');
+ panel.hidden = false;
+ var list = panel.querySelector('ul');
+ item.install_warnings.forEach(function(warning) {
+ var li = document.createElement('li');
+ li[warning.isHTML ? 'innerHTML' : 'innerText'] = warning.message;
Nikita (slow) 2013/08/05 22:26:40 nit: Please use textContent instead of innerText.
zhchbin 2013/08/06 02:05:43 Done. The C++ side struct: InstallWarning[0] supp
+ list.appendChild(li);
+ });
+ }
+
this.setActiveViews_(item, node);
return node;

Powered by Google App Engine
This is Rietveld 408576698