[Apps Developer Tool] Show installation warnings as chrome://extensions.

chrome/browser/extensions/api/developer_private/developer_private_api.cc

Index: chrome/browser/extensions/api/developer_private/developer_private_api.cc
diff --git a/chrome/browser/extensions/api/developer_private/developer_private_api.cc b/chrome/browser/extensions/api/developer_private/developer_private_api.cc
index b6c766ac7cce0a6ae90a5b0aa8f524252bee798c..a38ca03207365d5ebd3c2c193476f6f6438704f8 100644
--- a/chrome/browser/extensions/api/developer_private/developer_private_api.cc
+++ b/chrome/browser/extensions/api/developer_private/developer_private_api.cc
@@ -53,6 +53,7 @@
 #include "extensions/browser/view_type_utils.h"
 #include "extensions/common/constants.h"
 #include "extensions/common/extension_resource.h"
+#include "extensions/common/install_warning.h"
 #include "extensions/common/switches.h"
 #include "grit/chromium_strings.h"
 #include "grit/generated_resources.h"
@@ -299,6 +300,20 @@ scoped_ptr<developer::ItemInfo>
   if (Manifest::IsUnpackedLocation(item.location())) {
     info->path.reset(
         new std::string(UTF16ToUTF8(item.path().LossyDisplayName())));
+    const std::vector<extensions::InstallWarning>& install_warnings =
+        item.install_warnings();
+    if (!install_warnings.empty()) {
+      info->install_warnings.reset(
+          new std::vector<linked_ptr<developer::InstallWarning> >());
+      for (std::vector<extensions::InstallWarning>::const_iterator it =
+               install_warnings.begin(); it != install_warnings.end(); ++it) {
+        linked_ptr<developer::InstallWarning> install_warning(
+            new developer::InstallWarning());
+        install_warning->is_html = (it->format == InstallWarning::FORMAT_HTML);
+        install_warning->message = it->message;
+        info->install_warnings->push_back(install_warning);
+      }
+    }

[not at google - send to devlin, 2013/08/05 18:21:23]

instead:

info->path.reset(...)
for (std::vector<extensions::InstallWarning>::const_iterator it =
         item.install_warnings().begin();
     it != item.install_warnings().end(); ++it) {
  developer::InstallWarning* warning = new developer::InstallWarning();
  warning->is_html = ...;
  warning->message = it->message;
  info->install_warnings->push_back(make_linked_ptr(warning));
}

less code and identical effect.

[zhchbin, 2013/08/06 02:05:43]

Done.

   }
 
   info->incognito_enabled = service->IsIncognitoEnabled(item.id());