[Apps Developer Tool] Show installation warnings as chrome://extensions.

chrome/browser/extensions/api/developer_private/developer_private_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/developer_private/developer_private_api.h"
 
 #include "apps/app_load_service.h"
 #include "apps/app_restore_service.h"
 #include "apps/saved_files_service.h"
 #include "apps/shell_window.h"
@@ skipping 35 matching lines @@
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/site_instance.h"
 #include "content/public/browser/storage_partition.h"
 #include "content/public/browser/web_contents.h"
 #include "extensions/browser/view_type_utils.h"
 #include "extensions/common/constants.h"
 #include "extensions/common/extension_resource.h"
+#include "extensions/common/install_warning.h"
 #include "extensions/common/switches.h"
 #include "grit/chromium_strings.h"
 #include "grit/generated_resources.h"
 #include "net/base/net_util.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/webui/web_ui_util.h"
 #include "webkit/browser/fileapi/file_system_context.h"
 #include "webkit/browser/fileapi/file_system_operation.h"
 #include "webkit/browser/fileapi/file_system_operation_runner.h"
 #include "webkit/browser/fileapi/syncable/syncable_file_system_util.h"
@@ skipping 226 matching lines @@
     info->type = developer::ITEM_TYPE_THEME;
   } else if (item.is_extension()) {
     info->type = developer::ITEM_TYPE_EXTENSION;
   } else {
     NOTREACHED();
   }
 
   if (Manifest::IsUnpackedLocation(item.location())) {
     info->path.reset(
         new std::string(UTF16ToUTF8(item.path().LossyDisplayName())));
+    const std::vector<extensions::InstallWarning>& install_warnings =
+        item.install_warnings();
+    if (!install_warnings.empty()) {
+      info->install_warnings.reset(
+          new std::vector<linked_ptr<developer::InstallWarning> >());
+      for (std::vector<extensions::InstallWarning>::const_iterator it =
+               install_warnings.begin(); it != install_warnings.end(); ++it) {
+        linked_ptr<developer::InstallWarning> install_warning(
+            new developer::InstallWarning());
+        install_warning->is_html = (it->format == InstallWarning::FORMAT_HTML);
+        install_warning->message = it->message;
+        info->install_warnings->push_back(install_warning);
+      }
+    }

[not at google - send to devlin, 2013/08/05 18:21:23]

instead:

info->path.reset(...)
for (std::vector<extensions::InstallWarning>::const_iterator it =
         item.install_warnings().begin();
     it != item.install_warnings().end(); ++it) {
  developer::InstallWarning* warning = new developer::InstallWarning();
  warning->is_html = ...;
  warning->message = it->message;
  info->install_warnings->push_back(make_linked_ptr(warning));
}

less code and identical effect.

[zhchbin, 2013/08/06 02:05:43]

Done.

   }
 
   info->incognito_enabled = service->IsIncognitoEnabled(item.id());
   info->wants_file_access = item.wants_file_access();
   info->allow_file_access = service->AllowFileAccess(&item);
   info->allow_reload = Manifest::IsUnpackedLocation(item.location());
   info->is_unpacked = Manifest::IsUnpackedLocation(item.location());
   info->terminated = service->terminated_extensions()->Contains(item.id());
   info->allow_incognito = item.can_be_incognito_enabled();
 
@@ skipping 945 matching lines @@
 
   #undef   SET_STRING
   return true;
 }
 
 DeveloperPrivateGetStringsFunction::~DeveloperPrivateGetStringsFunction() {}
 
 } // namespace api
 
 } // namespace extensions