Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Unified Diff: content/renderer/media/renderer_webmediaplayer_delegate_browsertest.cc

Issue 2218963003: Added metrics for background video playback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated the browser test Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/media/renderer_webmediaplayer_delegate.cc ('k') | tools/metrics/actions/actions.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/renderer_webmediaplayer_delegate_browsertest.cc
diff --git a/content/renderer/media/renderer_webmediaplayer_delegate_browsertest.cc b/content/renderer/media/renderer_webmediaplayer_delegate_browsertest.cc
index 060f391c23f6fedd020e612b72cfd099ad2e480f..3a68e4df9b6f812e09d646280a01419d4dab51ee 100644
--- a/content/renderer/media/renderer_webmediaplayer_delegate_browsertest.cc
+++ b/content/renderer/media/renderer_webmediaplayer_delegate_browsertest.cc
@@ -9,6 +9,7 @@
#include "base/location.h"
#include "base/run_loop.h"
#include "base/single_thread_task_runner.h"
+#include "base/test/histogram_tester.h"
#include "base/test/simple_test_tick_clock.h"
#include "base/threading/thread_task_runner_handle.h"
#include "content/common/media/media_player_delegate_messages.h"
@@ -366,5 +367,41 @@ TEST_F(RendererWebMediaPlayerDelegateTest, IsPlayingBackgroundVideo) {
EXPECT_NE(old_value, delegate_manager_->IsPlayingBackgroundVideo());
}
+#if defined(OS_ANDROID)
+
+TEST_F(RendererWebMediaPlayerDelegateTest, Histograms) {
+ MockWebMediaPlayerDelegateObserver observer;
+ int delegate_id = delegate_manager_->AddObserver(&observer);
+ base::HistogramTester histogram_tester;
+ histogram_tester.ExpectTotalCount("Media.Android.BackgroundVideoTime", 0);
+
+ // Pausing or showing doesn't record anything as background playback
+ // hasn't started yet.
+ delegate_manager_->DidPlay(
+ delegate_id, true, true, false, base::TimeDelta());
+ CallOnMediaDelegatePause(delegate_id);
+ histogram_tester.ExpectTotalCount("Media.Android.BackgroundVideoTime", 0);
+
+ delegate_manager_->DidPlay(
+ delegate_id, true, true, false, base::TimeDelta());
+ delegate_manager_->WasShown();
+ histogram_tester.ExpectTotalCount("Media.Android.BackgroundVideoTime", 0);
+
+ // Doing this things after the background playback has started should record
+ // the time.
+ delegate_manager_->DidPlay(
+ delegate_id, true, true, false, base::TimeDelta());
+ SetPlayingBackgroundVideo(true);
+ CallOnMediaDelegatePause(delegate_id);
+ histogram_tester.ExpectTotalCount("Media.Android.BackgroundVideoTime", 1);
+
+ delegate_manager_->DidPlay(
+ delegate_id, true, true, false, base::TimeDelta());
+ SetPlayingBackgroundVideo(true);
+ delegate_manager_->WasShown();
+ histogram_tester.ExpectTotalCount("Media.Android.BackgroundVideoTime", 2);
+}
+
+#endif // OS_ANDROID
} // namespace media
« no previous file with comments | « content/renderer/media/renderer_webmediaplayer_delegate.cc ('k') | tools/metrics/actions/actions.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698