Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Side by Side Diff: content/renderer/media/renderer_webmediaplayer_delegate_browsertest.cc

Issue 2218963003: Added metrics for background video playback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated the browser test Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <tuple> 5 #include <tuple>
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/bind_helpers.h" 8 #include "base/bind_helpers.h"
9 #include "base/location.h" 9 #include "base/location.h"
10 #include "base/run_loop.h" 10 #include "base/run_loop.h"
11 #include "base/single_thread_task_runner.h" 11 #include "base/single_thread_task_runner.h"
12 #include "base/test/histogram_tester.h"
12 #include "base/test/simple_test_tick_clock.h" 13 #include "base/test/simple_test_tick_clock.h"
13 #include "base/threading/thread_task_runner_handle.h" 14 #include "base/threading/thread_task_runner_handle.h"
14 #include "content/common/media/media_player_delegate_messages.h" 15 #include "content/common/media/media_player_delegate_messages.h"
15 #include "content/public/renderer/render_view.h" 16 #include "content/public/renderer/render_view.h"
16 #include "content/public/test/render_view_test.h" 17 #include "content/public/test/render_view_test.h"
17 #include "content/renderer/media/renderer_webmediaplayer_delegate.h" 18 #include "content/renderer/media/renderer_webmediaplayer_delegate.h"
18 #include "content/renderer/render_process.h" 19 #include "content/renderer/render_process.h"
19 #include "testing/gmock/include/gmock/gmock.h" 20 #include "testing/gmock/include/gmock/gmock.h"
20 #include "testing/gtest/include/gtest/gtest.h" 21 #include "testing/gtest/include/gtest/gtest.h"
21 22
(...skipping 337 matching lines...) Expand 10 before | Expand all | Expand 10 after
359 delegate_manager_->DidPause(delegate_id, true); 360 delegate_manager_->DidPause(delegate_id, true);
360 CallOnMediaDelegatePlay(delegate_id); 361 CallOnMediaDelegatePlay(delegate_id);
361 EXPECT_EQ(old_value, delegate_manager_->IsPlayingBackgroundVideo()); 362 EXPECT_EQ(old_value, delegate_manager_->IsPlayingBackgroundVideo());
362 363
363 delegate_manager_->DidPlay( 364 delegate_manager_->DidPlay(
364 delegate_id, true, true, false, base::TimeDelta()); 365 delegate_id, true, true, false, base::TimeDelta());
365 CallOnMediaDelegatePlay(delegate_id); 366 CallOnMediaDelegatePlay(delegate_id);
366 EXPECT_NE(old_value, delegate_manager_->IsPlayingBackgroundVideo()); 367 EXPECT_NE(old_value, delegate_manager_->IsPlayingBackgroundVideo());
367 } 368 }
368 369
370 #if defined(OS_ANDROID)
371
372 TEST_F(RendererWebMediaPlayerDelegateTest, Histograms) {
373 MockWebMediaPlayerDelegateObserver observer;
374 int delegate_id = delegate_manager_->AddObserver(&observer);
375 base::HistogramTester histogram_tester;
376 histogram_tester.ExpectTotalCount("Media.Android.BackgroundVideoTime", 0);
377
378 // Pausing or showing doesn't record anything as background playback
379 // hasn't started yet.
380 delegate_manager_->DidPlay(
381 delegate_id, true, true, false, base::TimeDelta());
382 CallOnMediaDelegatePause(delegate_id);
383 histogram_tester.ExpectTotalCount("Media.Android.BackgroundVideoTime", 0);
384
385 delegate_manager_->DidPlay(
386 delegate_id, true, true, false, base::TimeDelta());
387 delegate_manager_->WasShown();
388 histogram_tester.ExpectTotalCount("Media.Android.BackgroundVideoTime", 0);
389
390 // Doing this things after the background playback has started should record
391 // the time.
392 delegate_manager_->DidPlay(
393 delegate_id, true, true, false, base::TimeDelta());
394 SetPlayingBackgroundVideo(true);
395 CallOnMediaDelegatePause(delegate_id);
396 histogram_tester.ExpectTotalCount("Media.Android.BackgroundVideoTime", 1);
397
398 delegate_manager_->DidPlay(
399 delegate_id, true, true, false, base::TimeDelta());
400 SetPlayingBackgroundVideo(true);
401 delegate_manager_->WasShown();
402 histogram_tester.ExpectTotalCount("Media.Android.BackgroundVideoTime", 2);
403 }
404
405 #endif // OS_ANDROID
369 406
370 } // namespace media 407 } // namespace media
OLDNEW
« no previous file with comments | « content/renderer/media/renderer_webmediaplayer_delegate.cc ('k') | tools/metrics/actions/actions.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698