third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h - Issue 2218943002: Introduce ServiceWorker.EventDispatchingDelay UMA

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h

Issue 2218943002: Introduce ServiceWorker.EventDispatchingDelay UMA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: diff from https://codereview.chromium.org/2249063004/#ps40001 Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_metrics.cc ('K') | « third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h

diff --git a/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h b/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h

index cf3adabf5dc9e9e12811eea5d7fca6b8b7058b24..43223ad2a9d5b65c7b0394f987cb2814844da6d4 100644

--- a/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h

+++ b/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h

@@ -124,8 +124,8 @@ public:

// lifecycle. When no response is provided, the browser should fallback to

// native fetch. EventIDs are the same with the ids passed from

// dispatchFetchEvent respectively.

- virtual void respondToFetchEvent(int responseID) { };

- virtual void respondToFetchEvent(int responseID, const WebServiceWorkerResponse& response) { };

+ virtual void respondToFetchEvent(int responseID, double eventDispatchTime) { };

+ virtual void respondToFetchEvent(int responseID, const WebServiceWorkerResponse& response, double eventDispatchTime) { };

virtual void didHandleFetchEvent(int eventFinishID, WebServiceWorkerEventResult result) { };

// ServiceWorker specific method. Called after InstallEvent (dispatched