third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp - Issue 2218943002: Introduce ServiceWorker.EventDispatchingDelay UMA

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp

Issue 2218943002: Introduce ServiceWorker.EventDispatchingDelay UMA (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: diff from https://codereview.chromium.org/2249063004/#ps40001 Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_metrics.cc ('K') | « third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp ('k') | third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp

diff --git a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp

index 4c1622ceac2716428f4506a2a9a4d1569b5f3f12..3d5dd8c98fdae4631b64f2f4a9429dcf6d5d0e4f 100644

--- a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp

+++ b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp

@@ -146,6 +146,7 @@ void ServiceWorkerGlobalScopeProxy::dispatchFetchEvent(int responseID, int event

eventInit.setIsReload(webRequest.isReload());

FetchEvent* fetchEvent = FetchEvent::create(workerGlobalScope()->scriptController()->getScriptState(), EventTypeNames::fetch, eventInit, respondWithObserver, waitUntilObserver);

waitUntilObserver->willDispatchEvent();

+ respondWithObserver->willDispatchEvent();

DispatchEventResult dispatchResult = workerGlobalScope()->dispatchEvent(fetchEvent);

respondWithObserver->didDispatchEvent(dispatchResult);

// false is okay because waitUntil for fetch event doesn't care about the

@@ -160,7 +161,7 @@ void ServiceWorkerGlobalScopeProxy::dispatchForeignFetchEvent(int responseID, in

// no events should be dispatched.

// TODO(mek): Ideally the browser wouldn't even start the service worker

// if its tokens have expired.

- ServiceWorkerGlobalScopeClient::from(workerGlobalScope())->respondToFetchEvent(responseID);

+ ServiceWorkerGlobalScopeClient::from(workerGlobalScope())->respondToFetchEvent(responseID, WTF::currentTime());

ServiceWorkerGlobalScopeClient::from(workerGlobalScope())->didHandleFetchEvent(eventFinishID, WebServiceWorkerEventResultCompleted);

return;

}

@@ -177,6 +178,7 @@ void ServiceWorkerGlobalScopeProxy::dispatchForeignFetchEvent(int responseID, in

eventInit.setOrigin(origin->toString());

ForeignFetchEvent* fetchEvent = ForeignFetchEvent::create(workerGlobalScope()->scriptController()->getScriptState(), EventTypeNames::foreignfetch, eventInit, respondWithObserver, waitUntilObserver);

waitUntilObserver->willDispatchEvent();

+ respondWithObserver->willDispatchEvent();

DispatchEventResult dispatchResult = workerGlobalScope()->dispatchEvent(fetchEvent);

respondWithObserver->didDispatchEvent(dispatchResult);

// false is okay because waitUntil for foreign fetch event doesn't care