Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Unified Diff: third_party/WebKit/Source/web/InspectorOverlay.cpp

Issue 2218603003: Timeline: show white overlay till page being reloaded paints (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: No message, just blanket Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/InspectorOverlay.cpp
diff --git a/third_party/WebKit/Source/web/InspectorOverlay.cpp b/third_party/WebKit/Source/web/InspectorOverlay.cpp
index e30b2572f5a5a89326ddc67829fb3dc32489cd8a..d97c6cb50c313e2ae6610d8996cbd3b637796751 100644
--- a/third_party/WebKit/Source/web/InspectorOverlay.cpp
+++ b/third_party/WebKit/Source/web/InspectorOverlay.cpp
@@ -179,6 +179,7 @@ InspectorOverlay::InspectorOverlay(WebViewImpl* webViewImpl)
, m_omitTooltip(false)
, m_timer(this, &InspectorOverlay::onTimer)
, m_suspended(false)
+ , m_showReloadingBlanket(false)
, m_inLayout(false)
, m_needsUpdate(false)
, m_inspectMode(InspectorDOMAgent::NotSearching)
@@ -294,6 +295,23 @@ void InspectorOverlay::setPausedInDebuggerMessage(const String& message)
scheduleUpdate();
}
+void InspectorOverlay::showReloadingBlanket()
+{
+ m_showReloadingBlanket = true;
+ scheduleUpdate();
+}
+
+void InspectorOverlay::maybeClearReloadingBlanket()
+{
+ if (!m_showReloadingBlanket)
+ return;
+ m_showReloadingBlanket = false;
+ if (m_suspended)
+ clearInternal();
+ else
+ scheduleUpdate();
+}
+
void InspectorOverlay::hideHighlight()
{
m_highlightNode.clear();
@@ -354,6 +372,8 @@ void InspectorOverlay::highlightQuad(std::unique_ptr<FloatQuad> quad, const Insp
bool InspectorOverlay::isEmpty()
{
+ if (m_showReloadingBlanket)
+ return false;
if (m_suspended)
return true;
bool hasVisibleElements = m_highlightNode || m_eventTargetNode || m_highlightQuad || (m_resizeTimerActive && m_drawViewSize) || !m_pausedInDebuggerMessage.isNull();
@@ -388,6 +408,10 @@ void InspectorOverlay::rebuildOverlayPage()
reset(viewportSize, visibleRectInDocument.location());
+ if (m_showReloadingBlanket) {
+ evaluateInOverlay("showReloadingBlanket", "");
+ return;
+ }
drawNodeHighlight();
drawQuadHighlight();
drawPausedInDebuggerMessage();
@@ -676,6 +700,8 @@ void InspectorOverlay::suspend()
m_suspended = true;
clearInternal();
}
+ m_suspended = true;
dgozman 2016/08/10 21:28:37 This code looks strange.
+ clearInternal();
}
void InspectorOverlay::resume()

Powered by Google App Engine
This is Rietveld 408576698