Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1225)

Unified Diff: third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp

Issue 2218603003: Timeline: show white overlay till page being reloaded paints (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: cleanup Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp b/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
index 087fe335b8344806be73f37c313371bab207c1e4..90c6bdd37bf47f8952eb29afbd9875ddad580073 100644
--- a/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
+++ b/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
@@ -521,6 +521,12 @@ void WebDevToolsAgentImpl::didRemovePageOverlay(const GraphicsLayer* layer)
m_layerTreeAgent->didRemovePageOverlay(layer);
}
+void WebDevToolsAgentImpl::rootLayerCleared()
+{
+ if (m_overlay)
+ m_overlay->maybeClearReloadingBanner();
+}
+
void WebDevToolsAgentImpl::layerTreeViewChanged(WebLayerTreeView* layerTreeView)
{
m_layerTreeId = layerTreeView ? layerTreeView->layerTreeId() : 0;
@@ -528,10 +534,12 @@ void WebDevToolsAgentImpl::layerTreeViewChanged(WebLayerTreeView* layerTreeView)
m_tracingAgent->setLayerTreeId(m_layerTreeId);
}
-void WebDevToolsAgentImpl::enableTracing(const String& categoryFilter)
+void WebDevToolsAgentImpl::enableTracing(const String& categoryFilter, const String& reloadingBannerMessage)
{
if (m_client)
m_client->enableTracing(categoryFilter);
+ if (!reloadingBannerMessage.isNull() && m_overlay)
+ m_overlay->setReloadingBanner(reloadingBannerMessage);
}
void WebDevToolsAgentImpl::disableTracing()

Powered by Google App Engine
This is Rietveld 408576698