Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Side by Side Diff: third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp

Issue 2218603003: Timeline: show white overlay till page being reloaded paints (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: cleanup Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010-2011 Google Inc. All rights reserved. 2 * Copyright (C) 2010-2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 503 matching lines...) Expand 10 before | Expand all | Expand 10 after
514 if (m_layerTreeAgent) 514 if (m_layerTreeAgent)
515 m_layerTreeAgent->willAddPageOverlay(layer); 515 m_layerTreeAgent->willAddPageOverlay(layer);
516 } 516 }
517 517
518 void WebDevToolsAgentImpl::didRemovePageOverlay(const GraphicsLayer* layer) 518 void WebDevToolsAgentImpl::didRemovePageOverlay(const GraphicsLayer* layer)
519 { 519 {
520 if (m_layerTreeAgent) 520 if (m_layerTreeAgent)
521 m_layerTreeAgent->didRemovePageOverlay(layer); 521 m_layerTreeAgent->didRemovePageOverlay(layer);
522 } 522 }
523 523
524 void WebDevToolsAgentImpl::rootLayerCleared()
525 {
526 if (m_overlay)
527 m_overlay->maybeClearReloadingBanner();
528 }
529
524 void WebDevToolsAgentImpl::layerTreeViewChanged(WebLayerTreeView* layerTreeView) 530 void WebDevToolsAgentImpl::layerTreeViewChanged(WebLayerTreeView* layerTreeView)
525 { 531 {
526 m_layerTreeId = layerTreeView ? layerTreeView->layerTreeId() : 0; 532 m_layerTreeId = layerTreeView ? layerTreeView->layerTreeId() : 0;
527 if (m_tracingAgent) 533 if (m_tracingAgent)
528 m_tracingAgent->setLayerTreeId(m_layerTreeId); 534 m_tracingAgent->setLayerTreeId(m_layerTreeId);
529 } 535 }
530 536
531 void WebDevToolsAgentImpl::enableTracing(const String& categoryFilter) 537 void WebDevToolsAgentImpl::enableTracing(const String& categoryFilter, const Str ing& reloadingBannerMessage)
532 { 538 {
533 if (m_client) 539 if (m_client)
534 m_client->enableTracing(categoryFilter); 540 m_client->enableTracing(categoryFilter);
541 if (!reloadingBannerMessage.isNull() && m_overlay)
542 m_overlay->setReloadingBanner(reloadingBannerMessage);
535 } 543 }
536 544
537 void WebDevToolsAgentImpl::disableTracing() 545 void WebDevToolsAgentImpl::disableTracing()
538 { 546 {
539 if (m_client) 547 if (m_client)
540 m_client->disableTracing(); 548 m_client->disableTracing();
541 } 549 }
542 550
543 void WebDevToolsAgentImpl::setCPUThrottlingRate(double rate) 551 void WebDevToolsAgentImpl::setCPUThrottlingRate(double rate)
544 { 552 {
(...skipping 124 matching lines...) Expand 10 before | Expand all | Expand 10 after
669 bool WebDevToolsAgent::shouldInterruptForMethod(const WebString& method) 677 bool WebDevToolsAgent::shouldInterruptForMethod(const WebString& method)
670 { 678 {
671 return method == "Debugger.pause" 679 return method == "Debugger.pause"
672 || method == "Debugger.setBreakpoint" 680 || method == "Debugger.setBreakpoint"
673 || method == "Debugger.setBreakpointByUrl" 681 || method == "Debugger.setBreakpointByUrl"
674 || method == "Debugger.removeBreakpoint" 682 || method == "Debugger.removeBreakpoint"
675 || method == "Debugger.setBreakpointsActive"; 683 || method == "Debugger.setBreakpointsActive";
676 } 684 }
677 685
678 } // namespace blink 686 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698