third_party/WebKit/Source/devtools/front_end/sdk/TracingManager.js - Issue 2218603003: Timeline: show white overlay till page being reloaded paints

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/TracingManager.js

Issue 2218603003: Timeline: show white overlay till page being reloaded paints (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: cleanup Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/inspector/browser_protocol.json ('K') | « third_party/WebKit/Source/core/inspector/browser_protocol.json ('k') | third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js » ('j') | third_party/WebKit/Source/web/InspectorOverlay.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sdk/TracingManager.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/TracingManager.js b/third_party/WebKit/Source/devtools/front_end/sdk/TracingManager.js

index d5838a7dfe1dd2f0d27b592d0e04bd87cf9c91bc..ae00ec7eb3404efc5a0fb99dc3e3fa34115c85c7 100644

--- a/third_party/WebKit/Source/devtools/front_end/sdk/TracingManager.js

+++ b/third_party/WebKit/Source/devtools/front_end/sdk/TracingManager.js

@@ -111,15 +111,16 @@ WebInspector.TracingManager.prototype = {

* @param {!WebInspector.TracingManagerClient} client

* @param {string} categoryFilter

* @param {string} options

+ * @param {string=} reloadingBanner

* @param {function(?string)=} callback

- start: function(client, categoryFilter, options, callback)

+ start: function(client, categoryFilter, options, reloadingBanner, callback)

{

if (this._activeClient)

throw new Error("Tracing is already started");

var bufferUsageReportingIntervalMs = 500;

this._activeClient = client;

- this._target.tracingAgent().start(categoryFilter, options, bufferUsageReportingIntervalMs, WebInspector.TracingManager.TransferMode.ReportEvents, callback);

+ this._target.tracingAgent().start(categoryFilter, options, bufferUsageReportingIntervalMs, WebInspector.TracingManager.TransferMode.ReportEvents, undefined, reloadingBanner, callback);

this._activeClient.tracingStarted();