Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js

Issue 2218603003: Timeline: show white overlay till page being reloaded paints (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: cleanup Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js
diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js
index 6bc49a7d197ea8434c9f6ec5d4a3dacffa662b13..3824fba5e40ed70dc81ebf8424d4f32442cb0022 100644
--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js
+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js
@@ -26,8 +26,9 @@ WebInspector.TimelineController.prototype = {
* @param {boolean} captureMemory
* @param {boolean} capturePictures
* @param {boolean} captureFilmStrip
+ * @param {string=} reloadingBanner
*/
- startRecording: function(captureCauses, enableJSSampling, captureMemory, capturePictures, captureFilmStrip)
+ startRecording: function(captureCauses, enableJSSampling, captureMemory, capturePictures, captureFilmStrip, reloadingBanner)
{
function disabledByDefault(category)
{
@@ -66,7 +67,7 @@ WebInspector.TimelineController.prototype = {
categoriesArray.push(disabledByDefault("devtools.screenshot"));
var categories = categoriesArray.join(",");
- this._startRecordingWithCategories(categories, enableJSSampling);
+ this._startRecordingWithCategories(categories, enableJSSampling, reloadingBanner);
},
stopRecording: function()
@@ -161,9 +162,10 @@ WebInspector.TimelineController.prototype = {
/**
* @param {string} categories
* @param {boolean=} enableJSSampling
+ * @param {string=} reloadingBanner
* @param {function(?string)=} callback
*/
- _startRecordingWithCategories: function(categories, enableJSSampling, callback)
+ _startRecordingWithCategories: function(categories, enableJSSampling, reloadingBanner, callback)
{
WebInspector.targetManager.suspendAllTargets();
var profilingStartedPromise = enableJSSampling && !Runtime.experiments.isEnabled("timelineTracingJSProfile") ?
@@ -173,7 +175,7 @@ WebInspector.TimelineController.prototype = {
var target = this._target;
var tracingManager = target.tracingManager;
target.resourceTreeModel.suspendReload();
- profilingStartedPromise.then(tracingManager.start.bind(tracingManager, this, categories, options, onTraceStarted));
+ profilingStartedPromise.then(tracingManager.start.bind(tracingManager, this, categories, options, reloadingBanner, onTraceStarted));
/**
* @param {?string} error
*/

Powered by Google App Engine
This is Rietveld 408576698