Backporting JSONValues from protocol::Values

Backporting JSONValues from protocol::Values

This commit back-ports the changes made in the inspector's JSON value class into Blink's JSONValue, and updates existing uses of JSONValue to use the new API.

Significant changes:
 - JSONValue (and subclasses) are held in std::unique_ptrs, rather than being refcounted.
 - JSON objects distinguish between Integers and Doubles

This commit does not remove the various JSONArray::push* methods, as they are used extensively as convenience methods, and are consistent with the JSONObject::set* methods.

BUG=634921
Committed: https://crrev.com/cc67aa8cfc7dd5672a05d85db883946d55c7a05a
Cr-Commit-Position: refs/heads/master@{#410066}

[iclelland, 2016-08-04 20:02:05]

The CQ bit was checked by iclelland@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 20:02:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 20:21:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 20:21:21]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[iclelland, 2016-08-04 20:41:35]

The CQ bit was checked by iclelland@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 20:42:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 00:28:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 00:28:09]

Dry run: This issue passed the CQ dry run.

[iclelland, 2016-08-05 03:24:37]

The CQ bit was checked by iclelland@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 03:24:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[iclelland, 2016-08-05 03:35:09]

Description was changed from

==========
Backporting JSONValues from Values

BUG=
==========

to

==========
Backporting JSONValues from protocol::Values

This commit back-ports the changes made in the inspector's JSON value class into
Blink's JSONValue, and updates existing uses of JSONValue to use the new API.

Significant changes:
 - JSONValue (and subclasses) are held in std::unique_ptrs, rather than being
refcounted.
 - JSON objects distinguish between Integers and Doubles

This commit does not remove the various JSONArray::push* methods, as they are
used extensively as convenience methods, and are consistent with the
JSONObject::set* methods.

BUG=
==========

[pfeldman, 2016-08-05 04:05:25]

pfeldman@chromium.org changed reviewers:
+ pfeldman@chromium.org

[pfeldman, 2016-08-05 04:05:27]

lgtm % comments

https://codereview.chromium.org/2218533002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/JSONValues.h (right):

https://codereview.chromium.org/2218533002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/JSONValues.h:80: ValueType type() const {
return m_type; }
We might have to leave this as getType(). See
https://chromium.googlesource.com/chromium/src/+/c5117b4cc2638739551a9eeedf5b....

https://codereview.chromium.org/2218533002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/JSONValues.h:88: virtual bool
asSerialized(String* output) const;
SerializedValue is inspector-specific, should be removed.

https://codereview.chromium.org/2218533002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/JSONValues.h:168: class PLATFORM_EXPORT
SerializedValue : public JSONValue {
SerializedValue is inspector-specific and should be removed.

[iclelland, 2016-08-05 04:59:35]

The CQ bit was checked by iclelland@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 04:59:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[iclelland, 2016-08-05 05:02:10]

Thanks for the quick review!

https://codereview.chromium.org/2218533002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/JSONValues.h (right):

https://codereview.chromium.org/2218533002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/JSONValues.h:80: ValueType type() const {
return m_type; }
On 2016/08/05 04:05:26, pfeldman wrote:
> We might have to leave this as getType(). See
>
https://chromium.googlesource.com/chromium/src/+/c5117b4cc2638739551a9eeedf5b....

Ahh, thanks. I didn't see the history behind that change, but it makes sense.
Reverted.

https://codereview.chromium.org/2218533002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/JSONValues.h:88: virtual bool
asSerialized(String* output) const;
On 2016/08/05 04:05:26, pfeldman wrote:
> SerializedValue is inspector-specific, should be removed.

Thanks. I was hoping that was the case. Done.

https://codereview.chromium.org/2218533002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/JSONValues.h:168: class PLATFORM_EXPORT
SerializedValue : public JSONValue {
On 2016/08/05 04:05:26, pfeldman wrote:
> SerializedValue is inspector-specific and should be removed.

Done.

[commit-bot: I haz the power, 2016-08-05 06:28:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 06:28:23]

Dry run: This issue passed the CQ dry run.

[iclelland, 2016-08-05 14:16:03]

The CQ bit was checked by iclelland@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 14:16:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[iclelland, 2016-08-05 14:30:40]

Description was changed from

==========
Backporting JSONValues from protocol::Values

This commit back-ports the changes made in the inspector's JSON value class into
Blink's JSONValue, and updates existing uses of JSONValue to use the new API.

Significant changes:
 - JSONValue (and subclasses) are held in std::unique_ptrs, rather than being
refcounted.
 - JSON objects distinguish between Integers and Doubles

This commit does not remove the various JSONArray::push* methods, as they are
used extensively as convenience methods, and are consistent with the
JSONObject::set* methods.

BUG=
==========

to

==========
Backporting JSONValues from protocol::Values

This commit back-ports the changes made in the inspector's JSON value class into
Blink's JSONValue, and updates existing uses of JSONValue to use the new API.

Significant changes:
 - JSONValue (and subclasses) are held in std::unique_ptrs, rather than being
refcounted.
 - JSON objects distinguish between Integers and Doubles

This commit does not remove the various JSONArray::push* methods, as they are
used extensively as convenience methods, and are consistent with the
JSONObject::set* methods.

BUG=634921
==========

[commit-bot: I haz the power, 2016-08-05 15:25:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 15:25:21]

Dry run: This issue passed the CQ dry run.

[iclelland, 2016-08-05 15:39:21]

The CQ bit was checked by iclelland@chromium.org

[iclelland, 2016-08-05 15:39:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2218533002/#ps80001
(title: "Switch back to partition allocator")

[commit-bot: I haz the power, 2016-08-05 15:39:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 15:43:44]

Description was changed from

==========
Backporting JSONValues from protocol::Values

This commit back-ports the changes made in the inspector's JSON value class into
Blink's JSONValue, and updates existing uses of JSONValue to use the new API.

Significant changes:
 - JSONValue (and subclasses) are held in std::unique_ptrs, rather than being
refcounted.
 - JSON objects distinguish between Integers and Doubles

This commit does not remove the various JSONArray::push* methods, as they are
used extensively as convenience methods, and are consistent with the
JSONObject::set* methods.

BUG=634921
==========

to

==========
Backporting JSONValues from protocol::Values

This commit back-ports the changes made in the inspector's JSON value class into
Blink's JSONValue, and updates existing uses of JSONValue to use the new API.

Significant changes:
 - JSONValue (and subclasses) are held in std::unique_ptrs, rather than being
refcounted.
 - JSON objects distinguish between Integers and Doubles

This commit does not remove the various JSONArray::push* methods, as they are
used extensively as convenience methods, and are consistent with the
JSONObject::set* methods.

BUG=634921
==========

[commit-bot: I haz the power, 2016-08-05 15:43:46]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-08-05 15:45:56]

Description was changed from

==========
Backporting JSONValues from protocol::Values

This commit back-ports the changes made in the inspector's JSON value class into
Blink's JSONValue, and updates existing uses of JSONValue to use the new API.

Significant changes:
 - JSONValue (and subclasses) are held in std::unique_ptrs, rather than being
refcounted.
 - JSON objects distinguish between Integers and Doubles

This commit does not remove the various JSONArray::push* methods, as they are
used extensively as convenience methods, and are consistent with the
JSONObject::set* methods.

BUG=634921
==========

to

==========
Backporting JSONValues from protocol::Values

This commit back-ports the changes made in the inspector's JSON value class into
Blink's JSONValue, and updates existing uses of JSONValue to use the new API.

Significant changes:
 - JSONValue (and subclasses) are held in std::unique_ptrs, rather than being
refcounted.
 - JSON objects distinguish between Integers and Doubles

This commit does not remove the various JSONArray::push* methods, as they are
used extensively as convenience methods, and are consistent with the
JSONObject::set* methods.

BUG=634921

Committed: https://crrev.com/cc67aa8cfc7dd5672a05d85db883946d55c7a05a
Cr-Commit-Position: refs/heads/master@{#410066}
==========

[commit-bot: I haz the power, 2016-08-05 15:45:58]

Patchset 5 (id:??) landed as
https://crrev.com/cc67aa8cfc7dd5672a05d85db883946d55c7a05a
Cr-Commit-Position: refs/heads/master@{#410066}