third_party/WebKit/Source/core/html/parser/XSSAuditorDelegate.cpp - Issue 2218533002: Backporting JSONValues from protocol::Values

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/parser/XSSAuditorDelegate.cpp

Issue 2218533002: Backporting JSONValues from protocol::Values (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Switch back to partition allocator Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/parser/XSSAuditorDelegate.cpp

diff --git a/third_party/WebKit/Source/core/html/parser/XSSAuditorDelegate.cpp b/third_party/WebKit/Source/core/html/parser/XSSAuditorDelegate.cpp

index 4b3b949fbb0a88f6e9253b5054b42b2980f3b38a..aaef92f50cae7aa8909febe935daf787dcc61ed4 100644

--- a/third_party/WebKit/Source/core/html/parser/XSSAuditorDelegate.cpp

+++ b/third_party/WebKit/Source/core/html/parser/XSSAuditorDelegate.cpp

@@ -90,12 +90,12 @@ PassRefPtr<EncodedFormData> XSSAuditorDelegate::generateViolationReport(const XS

httpBody = formData->flattenToString();

}

- RefPtr<JSONObject> reportDetails = JSONObject::create();

+ std::unique_ptr<JSONObject> reportDetails = JSONObject::create();

reportDetails->setString("request-url", xssInfo.m_originalURL);

reportDetails->setString("request-body", httpBody);

- RefPtr<JSONObject> reportObject = JSONObject::create();

- reportObject->setObject("xss-report", reportDetails.release());

+ std::unique_ptr<JSONObject> reportObject = JSONObject::create();

+ reportObject->setObject("xss-report", std::move(reportDetails));

return EncodedFormData::create(reportObject->toJSONString().utf8().data());

}