Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2218513002: Skip most tests that are currently broken w/ DrMemory. (Closed)

Created:
4 years, 4 months ago by Dirk Pranke
Modified:
4 years, 4 months ago
CC:
chromium-reviews, glider+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Skip most tests that are currently broken w/ DrMemory. After the switch from GYP->GN, some tests are passing, but most are still broken. In order to green up the tree, we'll skip the broken tests for now, and gradually re-enable them. R=thestig@chromium.org, groby@chromium.org NOTRY=true BUG=633693 Committed: https://crrev.com/7c24d26fa15ce41e869c719d572e10deb3d21a31 Cr-Commit-Position: refs/heads/master@{#409869}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix dup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -0 lines) Patch
M tools/valgrind/chrome_tests.py View 1 2 chunks +54 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Dirk Pranke
4 years, 4 months ago (2016-08-04 19:31:52 UTC) #1
Lei Zhang
lgtm Slightly heavy handed, but ok for now. https://codereview.chromium.org/2218513002/diff/1/tools/valgrind/chrome_tests.py File tools/valgrind/chrome_tests.py (right): https://codereview.chromium.org/2218513002/diff/1/tools/valgrind/chrome_tests.py#newcode803 tools/valgrind/chrome_tests.py:803: 'cc', ...
4 years, 4 months ago (2016-08-04 19:37:16 UTC) #2
Dirk Pranke
Yes, it's clearly heavy handed. A relatively straightforward next step is to gradually un-skip each ...
4 years, 4 months ago (2016-08-04 19:38:22 UTC) #3
Dirk Pranke
landing NOTRY=true since we don't have any drmem trybots and there's no point in running ...
4 years, 4 months ago (2016-08-04 19:39:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2218513002/20001
4 years, 4 months ago (2016-08-04 19:40:21 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-04 19:44:25 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 19:46:29 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7c24d26fa15ce41e869c719d572e10deb3d21a31
Cr-Commit-Position: refs/heads/master@{#409869}

Powered by Google App Engine
This is Rietveld 408576698