Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: tools/valgrind/chrome_tests.py

Issue 2218513002: Skip most tests that are currently broken w/ DrMemory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix dup Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/valgrind/chrome_tests.py
diff --git a/tools/valgrind/chrome_tests.py b/tools/valgrind/chrome_tests.py
index 458acfd216c5aef99ad2480a93bc3c613ae9873c..b362675916e0530ea909f3d8e578ca051ca11d92 100755
--- a/tools/valgrind/chrome_tests.py
+++ b/tools/valgrind/chrome_tests.py
@@ -735,6 +735,8 @@ def _main():
"as well.")
parser.add_option("--baseline", action="store_true", default=False,
help="generate baseline data instead of validating")
+ parser.add_option("-f", "--force", action="store_true", default=False,
+ help="run a broken test anyway")
parser.add_option("--gtest_filter",
help="additional arguments to --gtest_filter")
parser.add_option("--gtest_repeat", help="argument for --gtest_repeat")
@@ -793,7 +795,59 @@ def _main():
if len(options.test) != 1 and options.gtest_filter:
parser.error("--gtest_filter and multiple tests don't make sense together")
+ BROKEN_TESTS = {
+ 'drmemory_light': [
+ 'addressinput',
+ 'aura',
+ 'base_unittests',
+ 'cc',
+ 'components', # x64 only?
+ 'content',
+ 'gfx',
+ 'mojo_public_bindings',
+ ],
+ 'drmemory_full': [
+ 'addressinput',
+ 'aura',
+ 'base_unittests',
+ 'blink_heap',
+ 'blink_platform',
+ 'browser_tests',
+ 'cast',
+ 'cc',
+ 'chromedriver',
+ 'compositor',
+ 'content',
+ 'content_browsertests',
+ 'device',
+ 'events',
+ 'extensions',
+ 'gfx',
+ 'google_apis',
+ 'gpu',
+ 'ipc_tests',
+ 'jingle',
+ 'keyboard',
+ 'media',
+ 'midi',
+ 'mojo_common',
+ 'mojo_public_bindings',
+ 'mojo_public_sysperf',
+ 'mojo_public_system',
+ 'mojo_system',
+ 'net',
+ 'remoting',
+ 'unit',
+ 'url',
+ ],
+ }
+
for t in options.test:
+ if t in BROKEN_TESTS[options.valgrind_tool] and not options.force:
+ logging.info("Skipping broken %s test %s -- see crbug.com/633693" %
+ (options.valgrind_tool, t))
+ return 0
+
tests = ChromeTests(options, args, t)
ret = tests.Run()
if ret: return ret
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698