Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 2218473002: Beef up timer cancellation tests (Closed)

Created:
4 years, 4 months ago by Tom Sepez
Modified:
4 years, 4 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Beef up timer cancellation tests Adds more questionable invocations of ClearTimeOut(). Also, checking that nothing happened is fragile. Log at least one thing to show that the code ran. Committed: https://pdfium.googlesource.com/pdfium/+/0fa54b80d488571f10d8a94f6740006f0bf4957c

Patch Set 1 #

Patch Set 2 : pass ordinary object #

Patch Set 3 : Nothing is not a good expected result #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -2 lines) Patch
M fpdfsdk/fpdfformfill_embeddertest.cpp View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M testing/resources/bug_620428.in View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
M testing/resources/bug_620428.pdf View 1 2 2 chunks +15 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Tom Sepez
Lei, for review.
4 years, 4 months ago (2016-08-04 18:42:42 UTC) #2
Lei Zhang
lgtm
4 years, 4 months ago (2016-08-04 19:03:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2218473002/40001
4 years, 4 months ago (2016-08-04 19:05:34 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 19:07:32 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/0fa54b80d488571f10d8a94f6740006f0bf4...

Powered by Google App Engine
This is Rietveld 408576698