fpdfsdk/fpdfformfill_embeddertest.cpp - Issue 2218473002: Beef up timer cancellation tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/fpdfformfill_embeddertest.cpp

Issue 2218473002: Beef up timer cancellation tests (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Nothing is not a good expected result Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/fpdfformfill_embeddertest.cpp

diff --git a/fpdfsdk/fpdfformfill_embeddertest.cpp b/fpdfsdk/fpdfformfill_embeddertest.cpp

index e2920e041bb9fdc9adfcb3f0821266ec1a116008..27b889085cbb28d726078c1dfefeae89e13ac28f 100644

--- a/fpdfsdk/fpdfformfill_embeddertest.cpp

+++ b/fpdfsdk/fpdfformfill_embeddertest.cpp

@@ -130,7 +130,8 @@ TEST_F(FPDFFormFillEmbeddertest, BUG_620428) {

UnloadPage(page);

const auto& alerts = delegate.GetAlerts();

- EXPECT_EQ(0U, alerts.size());

+ ASSERT_EQ(1U, alerts.size());

+ EXPECT_STREQ(L"done", alerts[0].message.c_str());

}

#endif // PDF_ENABLE_V8

« no previous file with comments | « no previous file | testing/resources/bug_620428.in » ('j') | no next file with comments »