Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 2218413004: Remove --goma-enable-compiler-info-cache option from compile.py (Closed)

Created:
4 years, 4 months ago by tikuta
Modified:
4 years, 4 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Remove --goma-enable-compiler-info-cache option from compile.py * compiler-info-cache is enabled by default BUG=631920 Committed: https://chromium.googlesource.com/chromium/tools/build/+/c6d5023583562d95e3f309a86c97929490265cc2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -26 lines) Patch
M scripts/slave/compile.py View 2 chunks +0 lines, -6 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/api.py View 1 chunk +0 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/config.py View 2 chunks +0 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Linux32_Goma_Canary__clobber_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Linux_Goma_Canary.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Linux_Goma_Canary__clobber_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Linux_Precise_Goma_LinkTest.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Mac_10_9_Goma_Canary.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Mac_10_9_Goma_Canary__clobber_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Mac_10_9_Goma_Canary__dbg_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Mac_10_9_Goma_Canary__dbg__clobber_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWin7Goma.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWin7Goma_clbr_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWin7Goma_dbg_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWin7Goma_dll_.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClangGoma.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinGoma.json View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinGoma_dll_.json View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
tikuta
4 years, 4 months ago (2016-08-09 04:16:40 UTC) #2
Yoshisato Yanagisawa
lgtm
4 years, 4 months ago (2016-08-09 04:30:48 UTC) #3
shinyak
lgtm
4 years, 4 months ago (2016-08-09 05:03:53 UTC) #4
ukai
lgtm
4 years, 4 months ago (2016-08-09 05:40:58 UTC) #5
Paweł Hajdan Jr.
LGTM
4 years, 4 months ago (2016-08-09 07:05:19 UTC) #6
tikuta
Thank you for review. I commit this CL.
4 years, 4 months ago (2016-08-09 07:10:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2218413004/1
4 years, 4 months ago (2016-08-09 07:10:27 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 07:14:52 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/c6d5023583562d95e3f3...

Powered by Google App Engine
This is Rietveld 408576698