scripts/slave/recipe_modules/chromium/config.py - Issue 2218413004: Remove --goma-enable-compiler-info-cache option from compile.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/chromium/config.py

Issue 2218413004: Remove --goma-enable-compiler-info-cache option from compile.py (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipe_modules/chromium/api.py ('k') | scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Linux32_Goma_Canary__clobber_.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipe_modules/chromium/config.py

diff --git a/scripts/slave/recipe_modules/chromium/config.py b/scripts/slave/recipe_modules/chromium/config.py

index 98b8d68219f36b321b0306f9959a43931501bfff..68031a3509d974f847973547bd01af344dc9a865 100644

--- a/scripts/slave/recipe_modules/chromium/config.py

+++ b/scripts/slave/recipe_modules/chromium/config.py

@@ -43,8 +43,6 @@ def BaseConfig(HOST_PLATFORM, HOST_ARCH, HOST_BITS,

goma_hermetic = Single(basestring, required=False),

goma_enable_remote_link = Single(bool, empty_val=False, required=False),

goma_store_local_run_output = Single(bool, empty_val=False, required=False),

- goma_enable_compiler_info_cache = Single(

- bool, empty_val=False, required=False),

xcode_sdk = Single(basestring, required=False),

ninja_confirm_noop = Single(bool, empty_val=False, required=False),

set_build_data_dir = Single(bool, empty_val=False, required=False),

@@ -252,7 +250,6 @@ def msvs2015(c):

def goma_canary(c):

c.compile_py.goma_canary = True

c.compile_py.goma_hermetic = 'error'

- c.compile_py.goma_enable_compiler_info_cache = True

@config_ctx()

def goma_staging(c):